Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and test for misinterpreted dimensionless power of exponent #24066

Merged
merged 1 commit into from Oct 24, 2022
Merged

Fix and test for misinterpreted dimensionless power of exponent #24066

merged 1 commit into from Oct 24, 2022

Conversation

blackyblack
Copy link

References to other Issues or PRs

Fixes #24062

Brief description of what is fixed or changed

Added test for this issue in sympy/physics/units/tests/test_quantities.py
In _collect_factor_and_dimension() added additional check if expression is dimensionless.

Other comments

Release Notes

  • physics.units
    • Fixed a bug with dimensionless power of exponent

@sympy-bot
Copy link

sympy-bot commented Sep 16, 2022

Hi, I am the SymPy bot (v167). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.12.

Click here to see the pull request description that was parsed.
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
Fixes #24062


#### Brief description of what is fixed or changed
Added test for this issue in sympy/physics/units/tests/test_quantities.py
In _collect_factor_and_dimension() added additional check if expression is dimensionless.


#### Other comments


#### Release Notes

<!-- BEGIN RELEASE NOTES -->

* physics.units
  * Fixed a bug with dimensionless power of exponent

<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@oscarbenjamin oscarbenjamin added the physics.units Units and dimensions label Sep 22, 2022
@oscarbenjamin
Copy link
Contributor

You'll need to add yourself to .mailmap as mentioned in the failed authors test.

@github-actions
Copy link

Benchmark results from GitHub Actions

Lower numbers are good, higher numbers are bad. A ratio less than 1
means a speed up and greater than 1 means a slowdown. Green lines
beginning with + are slowdowns (the PR is slower then master or
master is slower than the previous release). Red lines beginning
with - are speedups.

Significantly changed benchmark results (PR vs master)

Significantly changed benchmark results (master vs previous release)

       before           after         ratio
     [41d90958]       [514579c6]
     <sympy-1.11.1^0>                 
-     1.36±0.04ms         877±40μs     0.65  solve.TimeSparseSystem.time_linear_eq_to_matrix(10)
-      3.96±0.2ms      1.62±0.04ms     0.41  solve.TimeSparseSystem.time_linear_eq_to_matrix(20)
-      7.75±0.2ms      2.43±0.05ms     0.31  solve.TimeSparseSystem.time_linear_eq_to_matrix(30)

Full benchmark results can be found as artifacts in GitHub Actions
(click on checks at the top of the PR).

@oscargus
Copy link
Contributor

Thanks!

@oscargus oscargus merged commit 2e5f03f into sympy:master Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
physics.units Units and dimensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SI._collect_factor_and_dimension() cannot properly detect that exponent is dimensionless
4 participants