Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - Cannot parse Greek characters (and possibly others) in parse_mathematica #24102

Merged
merged 4 commits into from Oct 5, 2022

Conversation

yvestumushimire
Copy link
Contributor

@yvestumushimire yvestumushimire commented Oct 1, 2022

Fix Cannot parse Greek characters (and possibly others) in parse_mathematica

References to other Issues or PRs

Fixes #24055

Brief description of what is fixed or changed

Skipping non ascii letters in tokeneziner.findall()

Other comments

Release Notes

  • parsing
    • Fix a bug with parsing Greek characters (and possibly others)

@sympy-bot
Copy link

sympy-bot commented Oct 1, 2022

Hi, I am the SymPy bot (v167). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.12.

Click here to see the pull request description that was parsed.
Fix Cannot parse Greek characters (and possibly others) in parse_mathematica

#### References to other Issues or PRs
Fixes #24055 

#### Brief description of what is fixed or changed
Skipping non ascii letters in `tokeneziner.findall()`

#### Other comments


#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* parsing
  *  Fix a bug with parsing Greek characters (and possibly others)
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@github-actions
Copy link

github-actions bot commented Oct 1, 2022

Benchmark results from GitHub Actions

Lower numbers are good, higher numbers are bad. A ratio less than 1
means a speed up and greater than 1 means a slowdown. Green lines
beginning with + are slowdowns (the PR is slower then master or
master is slower than the previous release). Red lines beginning
with - are speedups.

Significantly changed benchmark results (PR vs master)

Significantly changed benchmark results (master vs previous release)

       before           after         ratio
     [41d90958]       [58598660]
     <sympy-1.11.1^0>                 
+     1.19±0.06ms      1.84±0.07ms     1.54  solve.TimeRationalSystemSymbol.time_solve(1)
-     3.21±0.03ms      1.53±0.03ms     0.48  solve.TimeSparseSystem.time_linear_eq_to_matrix(20)
-     6.42±0.07ms       2.20±0.1ms     0.34  solve.TimeSparseSystem.time_linear_eq_to_matrix(30)

Full benchmark results can be found as artifacts in GitHub Actions
(click on checks at the top of the PR).

@oscarbenjamin
Copy link
Contributor

Looks good. Thanks!

@oscarbenjamin oscarbenjamin merged commit 10deed6 into sympy:master Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot parse Greek characters (and possibly others) in parse_mathematica
4 participants