Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Rewrite doesn't switch trig to hyperbolic functions #24235

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ramvikrams
Copy link

@ramvikrams ramvikrams commented Nov 8, 2022

References to other Issues or PRs

Fixes #24199

Brief description of what is fixed or changed

Fixed the problem for switching from trognometric to hyperbolic functions and added some missing conversions to
trignometric functions in hyperbolic functions

  • functions
    • Fixed a hyperbolic fuctions and added conversions from hyperbolic to trignometric functions.

@sympy-bot
Copy link

sympy-bot commented Nov 8, 2022

Hi, I am the SymPy bot (v167). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • functions
    • Fixed a hyperbolic fuctions and added conversions from hyperbolic to trignometric functions. (#24235 by @ramvikrams)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.12.

Click here to see the pull request description that was parsed.
#### References to other Issues or PRs
Fixes #24199 


#### Brief description of what is fixed or changed
Fixed the problem for switching from trognometric to hyperbolic functions and added some missing conversions to 
trignometric functions in hyperbolic functions
<!-- BEGIN RELEASE NOTES -->

* functions
  * Fixed a hyperbolic fuctions and added conversions from hyperbolic to trignometric functions.
<!-- END RELEASE NOTES -->

@oscarbenjamin
Copy link
Contributor

This has caused some tests to fail. It's possible that they should just be updated. You can run the relevant tests with:

$ pytest sympy/functions/elementary/tests/test_hyperbolic.py

@oscarbenjamin
Copy link
Contributor

I'm going to mark this PR as a draft. Feel free to mark it as ready for review once changes are made so that the tests can pass.

It is possible that the tests just need to be changed but the failures need to be investigated to see if that's the case.

@oscarbenjamin oscarbenjamin marked this pull request as draft November 24, 2022 18:24
@ramvikrams
Copy link
Author

I'm going to mark this PR as a draft. Feel free to mark it as ready for review once changes are made so that the tests can pass.

It is possible that the tests just need to be changed but the failures need to be investigated to see if that's the case.

Yes I'll do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite doesn't switch trig to hyperbolic functions
3 participants