Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(polys): fix printing elements of EX[x] #24248

Merged
merged 1 commit into from Nov 12, 2022

Conversation

oscarbenjamin
Copy link
Contributor

References to other Issues or PRs

Brief description of what is fixed or changed

On master printing elements of a ring with EX domain fails:

In [1]: str(EX[x].from_sympy(x))
---------------------------------------------------------------------------
SympifyError

This is due to PolyElement.str attempting to compare an element of the ground domain with an element of the ring. In the case of EX comparing with a PolyElement raises. Possibly that should be fixed but at least here we make sure that we are comparing elements of the same domain in str.

Release Notes

  • polys
    • A bug that prevented printing elements of polynomial rings over the EX domain was fixed.

@sympy-bot
Copy link

sympy-bot commented Nov 12, 2022

Hi, I am the SymPy bot (v167). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • polys
    • A bug that prevented printing elements of polynomial rings over the EX domain was fixed. (#24248 by @oscarbenjamin)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.12.

Click here to see the pull request description that was parsed.
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->


#### Brief description of what is fixed or changed

On master printing elements of a ring with `EX` domain fails:
```python
In [1]: str(EX[x].from_sympy(x))
---------------------------------------------------------------------------
SympifyError
```
This is due to `PolyElement.str` attempting to compare an element of the ground domain with an element of the ring. In the case of `EX` comparing with a `PolyElement` raises. Possibly that should be fixed but at least here we make sure that we are comparing elements of the same domain in `str`.

#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* polys
    * A bug that prevented printing elements of polynomial rings over the `EX` domain was fixed.
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@oscarbenjamin
Copy link
Contributor Author

The underlying error is this:

In [6]: EX(1) == EX[x].one
---------------------------------------------------------------------------
SympifyError

Generally == should return False rather than raising an exception. The way to do this is just to have __eq__ return NotImplemented if the other operand does not have the expected type.

@github-actions
Copy link

Benchmark results from GitHub Actions

Lower numbers are good, higher numbers are bad. A ratio less than 1
means a speed up and greater than 1 means a slowdown. Green lines
beginning with + are slowdowns (the PR is slower then master or
master is slower than the previous release). Red lines beginning
with - are speedups.

Significantly changed benchmark results (PR vs master)

Significantly changed benchmark results (master vs previous release)

       before           after         ratio
     [41d90958]       [ae895046]
     <sympy-1.11.1^0>                 
-     1.28±0.03ms         804±20μs     0.63  solve.TimeSparseSystem.time_linear_eq_to_matrix(10)
-     3.54±0.08ms      1.55±0.01ms     0.44  solve.TimeSparseSystem.time_linear_eq_to_matrix(20)
-      6.74±0.2ms      2.24±0.04ms     0.33  solve.TimeSparseSystem.time_linear_eq_to_matrix(30)

Full benchmark results can be found as artifacts in GitHub Actions
(click on checks at the top of the PR).

@sylee957 sylee957 merged commit 45572b5 into sympy:master Nov 12, 2022
@oscarbenjamin oscarbenjamin deleted the pr_ex_print branch November 29, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants