Geometric Distribution: Density function returning non-zero values #24995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Geometric Distribution pdf function so that for certain inputs,
the value of the "density function" (more properly, mass function)
should be 0, since the geometric value should be limited to integers
1 or greater if it's intended to be discrete and have the mass function
given in the documentation. Added tests to check non-zeron fractional
and negative input possibilities.
Example:
g = Geometric("G",p=S(1)/4)
assert density(g)(-1) == 0
assert density(g)(0.5) == 0
|
Hi, I am the SymPy bot. I'm here to help you write a release notes entry. Please read the guide on how to write release notes. ❌ There was an issue with the release notes. Please do not close this pull request; instead edit the description after reading the guide on how to write release notes.
Click here to see the pull request description that was parsed. |
1e9abhi1e10
reviewed
Mar 31, 2023
| @@ -76,6 +76,14 @@ def test_GeometricDistribution(): | |||
| Y = Geometric('Y', Rational(3, 10)) | |||
| assert coskewness(X, X + Y, X + 2*Y).simplify() == sqrt(230)*Rational(81, 1150) | |||
|
|
|||
| g = Geometric("G",p=S(1)/4) | |||
There was a problem hiding this comment.
should be a space after comma.
There was a problem hiding this comment.
Suggested change
| g = Geometric("G",p=S(1)/4) | |
| g = Geometric("G", p=S(1)/4) |
|
@akshaypkbhat Read here for writing the release notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original request: Issues with Geometric random variables #20031
Fixes non-zero outputs from geometric density function
Changed Geometric Distribution pdf function so that for certain inputs, the value of the "density function" (more properly, mass function) should be 0, since the geometric value should be limited to integers 1 or greater if it's intended to be discrete and have the mass function given in the documentation. Added tests to check non-zeron fractional and negative input possibilities.
Example:
g = Geometric("G",p=S(1)/4)
assert density(g)(-1) == 0
assert density(g)(0.5) == 0