Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs preview build #25361

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Conversation

asmeurer
Copy link
Member

See
scientific-python/circleci-artifacts-redirector-action#40 (comment)

I don't know if we will be able to see if this works without merging it. It should make the "click here to see the docs preview" build actually show up again.

References to other Issues or PRs

Brief description of what is fixed or changed

Other comments

Release Notes

NO ENTRY

@sympy-bot
Copy link

Hi, I am the SymPy bot (v170). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

  • No release notes entry will be added for this pull request.
Click here to see the pull request description that was parsed.
See
https://github.com/larsoner/circleci-artifacts-redirector-action/issues/40#issuecomment-1505543564

I don't know if we will be able to see if this works without merging it. It should make the "click here to see the docs preview" build actually show up again.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->


#### Brief description of what is fixed or changed


#### Other comments


#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers. Formerly, `log(-x)` incorrectly gave `-log(x)`.

* physics.units
  * Corrected a semantical error in the conversion between volt and statvolt which
    reported the volt as being larger than the statvolt.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
NO ENTRY
<!-- END RELEASE NOTES -->

@asmeurer
Copy link
Member Author

Don't know if this fixed it or not.

@oscarbenjamin
Copy link
Collaborator

Okay, I'll disable automerge for now.

@github-actions
Copy link

Benchmark results from GitHub Actions

Lower numbers are good, higher numbers are bad. A ratio less than 1
means a speed up and greater than 1 means a slowdown. Green lines
beginning with + are slowdowns (the PR is slower then master or
master is slower than the previous release). Red lines beginning
with - are speedups.

Significantly changed benchmark results (PR vs master)

Significantly changed benchmark results (master vs previous release)

Full benchmark results can be found as artifacts in GitHub Actions
(click on checks at the top of the PR).

@oscarbenjamin
Copy link
Collaborator

Maybe we need to merge it to see the effect.

@oscarbenjamin oscarbenjamin merged commit 56c9635 into sympy:master Jul 13, 2023
55 checks passed
@oscarbenjamin
Copy link
Collaborator

Maybe we need to merge it to see the effect.

I immediately received an email saying that the docs preview failed. Perhaps in a new PR it might work...

@asmeurer
Copy link
Member Author

Turns out I named the environment variable incorrectly when I added it to the repo. I fixed it now, so this should hopefully start working again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants