-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap scientific notation base raised to power between curly braces #26304
Wrap scientific notation base raised to power between curly braces #26304
Conversation
✅ Hi, I am the SymPy bot. I'm here to help you write a release notes entry. Please read the guide on how to write release notes.
Click here to see the pull request description that was parsed.
|
8999182
to
5dec5aa
Compare
e37ee8c
to
ec5cf4f
Compare
Printing scientific notation raised to a power in latex is not right. The base should be wrapped first between curly brackets as pointed out in the issue description. Also, a new testcase has been added to `test_latex.py`. This modification shall solve sympy#11011
ec5cf4f
to
545d14b
Compare
Benchmark results from GitHub Actions Lower numbers are good, higher numbers are bad. A ratio less than 1 Significantly changed benchmark results (PR vs master) Significantly changed benchmark results (master vs previous release) | Change | Before [a00718ba] | After [80660760] | Ratio | Benchmark (Parameter) |
|----------|----------------------|---------------------|---------|----------------------------------------------------------------------|
| - | 67.8±1ms | 44.5±0.3ms | 0.66 | integrate.TimeIntegrationRisch02.time_doit_risch(10) |
| + | 18.1±0.08μs | 30.5±0.7μs | 1.69 | integrate.TimeIntegrationRisch03.time_doit(1) |
| - | 5.32±0.01ms | 2.84±0.02ms | 0.53 | logic.LogicSuite.time_load_file |
| - | 74.0±0.5ms | 28.7±0.08ms | 0.39 | polys.TimeGCD_GaussInt.time_op(1, 'dense') |
| - | 26.1±0.2ms | 16.9±0.03ms | 0.65 | polys.TimeGCD_GaussInt.time_op(1, 'expr') |
| - | 73.6±1ms | 29.0±0.08ms | 0.39 | polys.TimeGCD_GaussInt.time_op(1, 'sparse') |
| - | 257±2ms | 124±0.2ms | 0.48 | polys.TimeGCD_GaussInt.time_op(2, 'dense') |
| - | 256±1ms | 126±0.4ms | 0.49 | polys.TimeGCD_GaussInt.time_op(2, 'sparse') |
| - | 660±4ms | 375±2ms | 0.57 | polys.TimeGCD_GaussInt.time_op(3, 'dense') |
| - | 653±3ms | 373±2ms | 0.57 | polys.TimeGCD_GaussInt.time_op(3, 'sparse') |
| - | 505±4μs | 284±1μs | 0.56 | polys.TimeGCD_LinearDenseQuadraticGCD.time_op(1, 'dense') |
| - | 1.79±0.01ms | 1.05±0ms | 0.58 | polys.TimeGCD_LinearDenseQuadraticGCD.time_op(2, 'dense') |
| - | 5.79±0.02ms | 3.09±0.02ms | 0.53 | polys.TimeGCD_LinearDenseQuadraticGCD.time_op(3, 'dense') |
| - | 460±6μs | 231±2μs | 0.5 | polys.TimeGCD_QuadraticNonMonicGCD.time_op(1, 'dense') |
| - | 1.49±0.01ms | 674±3μs | 0.45 | polys.TimeGCD_QuadraticNonMonicGCD.time_op(2, 'dense') |
| - | 4.94±0.01ms | 1.65±0.02ms | 0.33 | polys.TimeGCD_QuadraticNonMonicGCD.time_op(3, 'dense') |
| - | 375±4μs | 205±1μs | 0.55 | polys.TimeGCD_SparseGCDHighDegree.time_op(1, 'dense') |
| - | 2.47±0.01ms | 1.21±0.01ms | 0.49 | polys.TimeGCD_SparseGCDHighDegree.time_op(3, 'dense') |
| - | 10.2±0.02ms | 4.32±0.03ms | 0.42 | polys.TimeGCD_SparseGCDHighDegree.time_op(5, 'dense') |
| - | 358±2μs | 169±2μs | 0.47 | polys.TimeGCD_SparseNonMonicQuadratic.time_op(1, 'dense') |
| - | 2.52±0.01ms | 885±7μs | 0.35 | polys.TimeGCD_SparseNonMonicQuadratic.time_op(3, 'dense') |
| - | 9.62±0.09ms | 2.70±0.02ms | 0.28 | polys.TimeGCD_SparseNonMonicQuadratic.time_op(5, 'dense') |
| - | 1.03±0.01ms | 429±2μs | 0.42 | polys.TimePREM_LinearDenseQuadraticGCD.time_op(3, 'dense') |
| - | 1.72±0ms | 513±3μs | 0.3 | polys.TimePREM_LinearDenseQuadraticGCD.time_op(3, 'sparse') |
| - | 5.95±0.03ms | 1.79±0.01ms | 0.3 | polys.TimePREM_LinearDenseQuadraticGCD.time_op(5, 'dense') |
| - | 8.49±0.04ms | 1.54±0.01ms | 0.18 | polys.TimePREM_LinearDenseQuadraticGCD.time_op(5, 'sparse') |
| - | 284±0.9μs | 65.9±0.5μs | 0.23 | polys.TimePREM_QuadraticNonMonicGCD.time_op(1, 'sparse') |
| - | 3.51±0.02ms | 395±2μs | 0.11 | polys.TimePREM_QuadraticNonMonicGCD.time_op(3, 'dense') |
| - | 3.96±0.01ms | 283±0.8μs | 0.07 | polys.TimePREM_QuadraticNonMonicGCD.time_op(3, 'sparse') |
| - | 7.09±0.06ms | 1.27±0.02ms | 0.18 | polys.TimePREM_QuadraticNonMonicGCD.time_op(5, 'dense') |
| - | 8.85±0.03ms | 845±2μs | 0.1 | polys.TimePREM_QuadraticNonMonicGCD.time_op(5, 'sparse') |
| - | 5.03±0.01ms | 3.04±0ms | 0.6 | polys.TimeSUBRESULTANTS_LinearDenseQuadraticGCD.time_op(2, 'sparse') |
| - | 12.2±0.07ms | 6.55±0.02ms | 0.54 | polys.TimeSUBRESULTANTS_LinearDenseQuadraticGCD.time_op(3, 'dense') |
| - | 22.6±0.1ms | 9.19±0.04ms | 0.41 | polys.TimeSUBRESULTANTS_LinearDenseQuadraticGCD.time_op(3, 'sparse') |
| - | 5.20±0.04ms | 882±2μs | 0.17 | polys.TimeSUBRESULTANTS_QuadraticNonMonicGCD.time_op(1, 'sparse') |
| - | 12.7±0.02ms | 7.14±0.03ms | 0.56 | polys.TimeSUBRESULTANTS_QuadraticNonMonicGCD.time_op(2, 'sparse') |
| - | 103±1ms | 25.3±0.1ms | 0.25 | polys.TimeSUBRESULTANTS_QuadraticNonMonicGCD.time_op(3, 'dense') |
| - | 168±1ms | 54.8±0.4ms | 0.33 | polys.TimeSUBRESULTANTS_QuadraticNonMonicGCD.time_op(3, 'sparse') |
| - | 174±0.8μs | 110±2μs | 0.63 | polys.TimeSUBRESULTANTS_SparseGCDHighDegree.time_op(1, 'dense') |
| - | 368±3μs | 218±2μs | 0.59 | polys.TimeSUBRESULTANTS_SparseGCDHighDegree.time_op(1, 'sparse') |
| - | 4.29±0.01ms | 855±10μs | 0.2 | polys.TimeSUBRESULTANTS_SparseGCDHighDegree.time_op(3, 'dense') |
| - | 5.34±0.02ms | 389±1μs | 0.07 | polys.TimeSUBRESULTANTS_SparseGCDHighDegree.time_op(3, 'sparse') |
| - | 20.3±0.1ms | 2.81±0ms | 0.14 | polys.TimeSUBRESULTANTS_SparseGCDHighDegree.time_op(5, 'dense') |
| - | 23.1±0.2ms | 637±0.4μs | 0.03 | polys.TimeSUBRESULTANTS_SparseGCDHighDegree.time_op(5, 'sparse') |
| - | 493±6μs | 139±0.5μs | 0.28 | polys.TimeSUBRESULTANTS_SparseNonMonicQuadratic.time_op(1, 'sparse') |
| - | 4.86±0.1ms | 620±2μs | 0.13 | polys.TimeSUBRESULTANTS_SparseNonMonicQuadratic.time_op(3, 'dense') |
| - | 5.37±0.05ms | 141±0.8μs | 0.03 | polys.TimeSUBRESULTANTS_SparseNonMonicQuadratic.time_op(3, 'sparse') |
| - | 13.3±0.05ms | 1.30±0.01ms | 0.1 | polys.TimeSUBRESULTANTS_SparseNonMonicQuadratic.time_op(5, 'dense') |
| - | 14.2±0.2ms | 145±2μs | 0.01 | polys.TimeSUBRESULTANTS_SparseNonMonicQuadratic.time_op(5, 'sparse') |
| - | 133±1μs | 74.7±0.2μs | 0.56 | solve.TimeMatrixOperations.time_rref(3, 0) |
| - | 247±0.4μs | 86.9±0.6μs | 0.35 | solve.TimeMatrixOperations.time_rref(4, 0) |
| - | 24.2±0.2ms | 10.2±0.03ms | 0.42 | solve.TimeSolveLinSys189x49.time_solve_lin_sys |
| - | 28.0±0.07ms | 15.4±0.05ms | 0.55 | solve.TimeSparseSystem.time_linsolve_Aaug(20) |
| - | 54.3±0.3ms | 24.7±0.07ms | 0.45 | solve.TimeSparseSystem.time_linsolve_Aaug(30) |
| - | 27.8±0.1ms | 15.1±0.05ms | 0.54 | solve.TimeSparseSystem.time_linsolve_Ab(20) |
| - | 53.7±0.2ms | 24.5±0.05ms | 0.46 | solve.TimeSparseSystem.time_linsolve_Ab(30) |
Full benchmark results can be found as artifacts in GitHub Actions |
References to other Issues or PRs
Fixes #11011
Brief description of what is fixed or changed
Printing scientific notation raised to a power in latex is not right.
The base should be wrapped first between curly brackets {}s as pointed out in the
issue description.
Previous Behavior:
After the Patch:
Also, a new testcase has been added to
test_latex.py
Other comments
Release Notes
NO ENTRY