Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes dsolve function's error when given ics #26356

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

neel3998
Copy link

@neel3998 neel3998 commented Mar 13, 2024

  • solvers
    • Fixes#26343
    • When the ics solution is checked and the value is nan, then the issue occurs. This is fixed in pr.

@sympy-bot
Copy link

sympy-bot commented Mar 13, 2024

Hi, I am the SymPy bot. I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.13.

Click here to see the pull request description that was parsed.
<!-- BEGIN RELEASE NOTES -->
* solvers
   * Fixes#26343
   * When the ics solution is checked and the value is nan, then the issue occurs. This is fixed in pr.

<!-- END RELEASE NOTES -->

@neel3998 neel3998 changed the title Fixes dsolve function's error when given ics. Fixes dsolve function's error when given ics Mar 13, 2024
@1e9abhi1e10
Copy link
Contributor

Thanks for the fix. Kindly include your name in .mailmap and execute bin/mailmap_check.py.

Refer to https://docs.sympy.org/dev/contributing/new-contributors-guide/workflow-process.html#mailmap-instructions for guidance.

Additionally, modify the pull request description, incorporate release notes as per https://github.com/sympy/sympy/wiki/Writing-Release-Notes, and include the necessary test.

@neel3998
Copy link
Author

hi @1e9abhi1e10 @oscarbenjamin, can you please review this pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants