Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _eval_simplify method in Xor class to delegate simplification to superclass #26432

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Abhishekjsr283204
Copy link
Contributor

References to other Issues or PRs

Brief description of what is fixed or changed

fixes #25827
simplify works on the other expression because of _eval_simplify. The problem is that Xor._eval_simplify doesn't call super()._eval_simplify, unlike And._eval_simplify and Or._eval_simplify, which calls simplify_logic.

Other comments

Release Notes

  • logic
    • Added superclass's _eval_simplify method for more effective simplification of XOR expressions in the Xor class.

@sympy-bot
Copy link

Hi, I am the SymPy bot. I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • logic
    • Added superclass's _eval_simplify method for more effective simplification of XOR expressions in the Xor class. (#26432 by @Abhishekjsr283204)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.13.

Click here to see the pull request description that was parsed.
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->


#### Brief description of what is fixed or changed
fixes #25827
simplify works on the other expression because of _eval_simplify. The problem is that Xor._eval_simplify doesn't call super()._eval_simplify, unlike And._eval_simplify and Or._eval_simplify, which calls simplify_logic.

#### Other comments


#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers. Formerly, `log(-x)` incorrectly gave `-log(x)`.

* physics.units
  * Corrected a semantical error in the conversion between volt and statvolt which
    reported the volt as being larger than the statvolt.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* logic
  *   Added superclass's _eval_simplify method for more effective simplification of XOR expressions in the Xor class.
<!-- END RELEASE NOTES -->

@Abhishekjsr283204
Copy link
Contributor Author

Abhishekjsr283204 commented Mar 31, 2024

@asmeurer @sylee957 @oscarbenjamin sir please have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exclusive or (XOR) of a bool symbol and its negation should return True
2 participants