Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added is_even and is_odd methods to Min and Max #8646

Closed
wants to merge 1 commit into from

Conversation

shivamvats
Copy link
Member

Fixes #8640

@@ -419,6 +419,15 @@ def evalf(self, prec=None, **options):
def is_real(self):
return fuzzy_and(arg.is_real for arg in self.args)

@property
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No.

Please learn how work the old assumptions (see sympy/core/assumptions.py).

@pelegm
Copy link
Contributor

pelegm commented Dec 19, 2014

@skirpichev do you mind to elaborate? I usually copy-paste _eval_is... methods, but I do not really know what are the differences between "old" and "new" assumptions, and related practices. Is that documented somewhere?

I have looked into sympy/core/assumptions.py, but that was not informative enough...

@skirpichev
Copy link
Contributor

Is that documented somewhere?

Yes. Both old and new (sympy/assumptions) assumptions have some documentation.

I have looked into sympy/core/assumptions.py, but that was not informative enough...

Unfortunately, you should read the code first, before doing any modifications.

@debugger22
Copy link
Member

I think we can close this now. #8652 has the fix.

@shivamvats shivamvats closed this Dec 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Max forgets the is_even assumption
4 participants