Simplify ComplexPlane({x}*{y}) to FiniteSet(x + I*y) #9671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| obj = ImageSet.__new__(cls, Lambda((x, y), x + I*y), sets) | ||
|
|
||
| if (all([_a.is_FiniteSet for _a in sets.args]) and | ||
| all([len(_a) == 1 for _a in sets.args])): |
There was a problem hiding this comment.
You don't need the [] here, all() will work fine on a generator, and will make it not have to create a list. You can also combine these with _a.is_FiniteSet and len(_a) == 1 (tho that may not necessarily help performance)
There was a problem hiding this comment.
You should also check that you have exactly 2 args in sets
Signed-off-by: AMiT Kumar <dtu.amit@gmail.com>
|
+1 |
1 similar comment
|
+1 |
hargup
added a commit
that referenced
this pull request
Jul 22, 2015
Simplify ComplexPlane({x}*{y}) to FiniteSet(x + I*y)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify singleton Element in Complex Plane
ComplexPlane({x}*{y}).fixes #9669
Earlier:
Now:
EDIT TODO
@hargup @flacjacket @jksuom