-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Toggle shortcut for lua script #8
base: master
Are you sure you want to change the base?
Conversation
nice profile picture |
thank you! |
Wouldn't it make sense to only skip once ? |
Initially ani-skip only skipped once but then I changed it to skip everytime by taking inspiration from anime streaming sites. Let me take suggestions from few people regarding this issue. |
Yea skipping just once is a good idea, probably better than mine Something else i did for my script is removing a few seconds from the skip times to jumping 5s before what the op end time is. |
I agree. I think there should be a script-option for it, and switching skipping always or skipping once could also be done with them. For v2: |
Yea, those would be optimal. I wonder if theres a way to make ani-cli prefer ones with them, since right now they are few and far between from my experience. |
There will be two Lua scripts: skip-once.lua and skip-always.lua. Depending on the user's preference, ani-skip will return the appropriate flag. |
Adds a shortcut in to the lua script so you can toggle the script by pressing
i
for the rare cases where the api times are not quite correct or QoL when binging in ani-cli when using-r
to for example watch the opening once.Generally if they are off its only by like half a sentence from expirience, so not a totally necesary feature.
I also added it in to the Readme.md, its fine if you want to have it differently though.
Tested it extensively this time, so there shouldnt be any issues.