Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Toggle shortcut for lua script #8

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Woreec
Copy link

@Woreec Woreec commented Apr 13, 2024

Adds a shortcut in to the lua script so you can toggle the script by pressing i for the rare cases where the api times are not quite correct or QoL when binging in ani-cli when using -r to for example watch the opening once.

Generally if they are off its only by like half a sentence from expirience, so not a totally necesary feature.

I also added it in to the Readme.md, its fine if you want to have it differently though.

Tested it extensively this time, so there shouldnt be any issues.

@justchokingaround
Copy link
Collaborator

nice profile picture

@Woreec
Copy link
Author

Woreec commented Apr 13, 2024

thank you!

@Commandcracker
Copy link

Wouldn't it make sense to only skip once ?
Then you would be able to watch the opening/outro by rewinding, and you would also be able to instantly account for skips that are off by a bit.

@synacktraa
Copy link
Owner

Wouldn't it make sense to only skip once ?

Then you would be able to watch the opening/outro by rewinding, and you would also be able to instantly account for skips that are off by a bit.

Initially ani-skip only skipped once but then I changed it to skip everytime by taking inspiration from anime streaming sites. Let me take suggestions from few people regarding this issue.

@Woreec
Copy link
Author

Woreec commented May 5, 2024

Yea skipping just once is a good idea, probably better than mine

Something else i did for my script is removing a few seconds from the skip times to jumping 5s before what the op end time is.
Might be just personal preference but i rather have a few seconds of the op instead of missing a few seconsds of the episode.
Not sure if that is something but i thought i mention it since theres already a small discusion.

@Commandcracker
Copy link

Something else i did for my script is removing a few seconds from the skip times to jumping 5s before what the op end time is.
Might be just personal preference but i rather have a few seconds of the op instead of missing a few seconsds of the episode.

I agree. I think there should be a script-option for it, and switching skipping always or skipping once could also be done with them.

For v2:
Skipping times from start are streaming service dependent because some of them have extra intros. Doing skipping times from the end should make the skip times more consistent, but the end sometimes varies between languages and dubs, for example Overlord, it ends after the outro in the original language version, but the dub has some extra stuff at the end. This needs some testing, but it might make ani-skip better. Another thing: A few videos have metadata for segments, using them provides optimal skip times.

@Woreec
Copy link
Author

Woreec commented May 6, 2024

A few videos have metadata for segments, using them provides optimal skip times.

Yea, those would be optimal. I wonder if theres a way to make ani-cli prefer ones with them, since right now they are few and far between from my experience.

@synacktraa
Copy link
Owner

There will be two Lua scripts: skip-once.lua and skip-always.lua. Depending on the user's preference, ani-skip will return the appropriate flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants