Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move preflight deps behind build tags #287

Merged
merged 22 commits into from
Jun 20, 2024
Merged

Move preflight deps behind build tags #287

merged 22 commits into from
Jun 20, 2024

Conversation

jordan-rash
Copy link
Contributor

No description provided.

@jordan-rash
eod push
585f822 
Signed-off-by: Jordan Rash <15827604+jordan-rash@users.noreply.github.com>
@jordan-rash
appears to kinda work
8391af0 
Signed-off-by: Jordan Rash <15827604+jordan-rash@users.noreply.github.com>
@jordan-rash
typo
229d137 
Signed-off-by: Jordan Rash <15827604+jordan-rash@users.noreply.github.com>
@jordan-rash
fix path
50d38f9 
Signed-off-by: Jordan Rash <15827604+jordan-rash@users.noreply.github.com>
@jordan-rash
set bin path
2b73cc9 
Signed-off-by: Jordan Rash <15827604+jordan-rash@users.noreply.github.com>
@jordan-rash jordan-rash marked this pull request as ready for review June 18, 2024 20:05
@jordan-rash jordan-rash requested a review from a team as a code owner June 18, 2024 20:05
autodidaddict
autodidaddict previously approved these changes Jun 18, 2024
View reviewed changes
@jordan-rash
some cleanup
077aaa6 
Signed-off-by: Jordan Rash <15827604+jordan-rash@users.noreply.github.com>
@jordan-rash
suppress logs a bit
3f12b51 
Signed-off-by: Jordan Rash <15827604+jordan-rash@users.noreply.github.com>
@jordan-rash jordan-rash linked an issue Jun 18, 2024 that may be closed by this pull request
Refactor Preflight to use build tags #215
Closed
@jordan-rash
babies first spec
83ce406 
Signed-off-by: Jordan Rash <15827604+jordan-rash@users.noreply.github.com>
@jordan-rash
grr
236dd5d 
Signed-off-by: Jordan Rash <15827604+jordan-rash@users.noreply.github.com>
kthomas
kthomas reviewed Jun 19, 2024
View reviewed changes
spec/node_linux_test.go Outdated Show resolved Hide resolved
kthomas
kthomas previously approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@kthomas kthomas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the linter is tests are still unhappy, but this looks great otherwise.

@jordan-rash
try2
a384c55 
Signed-off-by: Jordan Rash <15827604+jordan-rash@users.noreply.github.com>
@jordan-rash
asdf
f479cc9 
Signed-off-by: Jordan Rash <15827604+jordan-rash@users.noreply.github.com>
@jordan-rash
ASdf
e687b57 
Signed-off-by: Jordan Rash <15827604+jordan-rash@users.noreply.github.com>
@jordan-rash
Asdf
445388e 
Signed-off-by: Jordan Rash <15827604+jordan-rash@users.noreply.github.com>
@jordan-rash
add to path
c3714b3 
Signed-off-by: Jordan Rash <15827604+jordan-rash@users.noreply.github.com>
@jordan-rash
Trigger Build
ab1805f
@jordan-rash
stop looking once found
64c2cbc 
Signed-off-by: Jordan Rash <15827604+jordan-rash@users.noreply.github.com>
@jordan-rash
better logic
9c0fba7 
Signed-off-by: Jordan Rash <15827604+jordan-rash@users.noreply.github.com>
@jordan-rash
troubleshooting line
07ca8ed 
Signed-off-by: Jordan Rash <15827604+jordan-rash@users.noreply.github.com>
kthomas
kthomas previously approved these changes Jun 19, 2024
View reviewed changes
@jordan-rash
Merge branch 'main' into fix/preflight_tags
4bfa09e
@jordan-rash
version setting matters
574b726 
Signed-off-by: Jordan Rash <15827604+jordan-rash@users.noreply.github.com>
@jordan-rash
make ginkgo only use stderr for test failures
02c62d2 
Signed-off-by: Jordan Rash <15827604+jordan-rash@users.noreply.github.com>
@jordan-rash jordan-rash requested a review from kthomas June 19, 2024 19:01
@jordan-rash jordan-rash merged commit 9d5db63 into main Jun 20, 2024
5 checks passed
@jordan-rash jordan-rash deleted the fix/preflight_tags branch June 20, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@autodidaddict autodidaddict autodidaddict approved these changes

@kthomas kthomas Awaiting requested review from kthomas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor Preflight to use build tags
3 participants
@jordan-rash @kthomas @autodidaddict