Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add make support for nested go modules #130

Merged
merged 5 commits into from
Aug 25, 2022
Merged

add make support for nested go modules #130

merged 5 commits into from
Aug 25, 2022

Conversation

trajan0x
Copy link
Contributor

@trajan0x trajan0x commented Aug 25, 2022

Description

Currently, go.Makefile does not support nested directories so sanguine/module/go.mod will work, but sanguine/module/a/go.mod will break because we use a hardcoded ../.golangci.yml. This fixes that issue + adds a go work sync command

Also adds a label for make changes

Additional context

Since scribe (#114) will go in a services directory, this is a prerequisite to that move

currently, go.Makefile does not support nested directories so sanguine/module/go.mod will work, but sanguine/module/a/go.mod will break because we use a hardcoded ../.golangci.yml. This fixes that issue + adds a go work sync command
@trajan0x trajan0x marked this pull request as ready for review August 25, 2022 15:41
@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #130 (4dac7f5) into master (e45c801) will decrease coverage by 0.19011%.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##              master        #130         +/-   ##
===================================================
- Coverage   51.61597%   51.42586%   -0.19011%     
===================================================
  Files            130         130                 
  Lines           5260        5260                 
  Branches          73          73                 
===================================================
- Hits            2715        2705         -10     
- Misses          2281        2297         +16     
+ Partials         264         258          -6     
Impacted Files Coverage Δ
...test/harnesses/SynapseClientUpgradeableHarness.sol 33.33333% <0.00000%> (-66.66668%) ⬇️
.../contracts/test/harnesses/SynapseClientHarness.sol 50.00000% <0.00000%> (-50.00000%) ⬇️
...ackages/contracts/test/harnesses/OriginHarness.sol 75.00000% <0.00000%> (-25.00000%) ⬇️
packages/contracts/contracts/Destination.sol 46.03175% <0.00000%> (-7.93650%) ⬇️
packages/contracts/contracts/Origin.sol 82.92683% <0.00000%> (-7.31708%) ⬇️
...kages/contracts/contracts/AttestationCollector.sol 97.67442% <0.00000%> (-2.32559%) ⬇️
...ges/contracts/contracts/system/SystemMessenger.sol 62.50000% <0.00000%> (ø)
...acts/contracts/client/SynapseClientUpgradeable.sol 90.90909% <0.00000%> (+9.09091%) ⬆️
...kages/contracts/contracts/client/SynapseClient.sol 100.00000% <0.00000%> (+10.00000%) ⬆️
packages/contracts/test/harnesses/AppHarness.sol 55.55556% <0.00000%> (+11.11111%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@trajan0x trajan0x mentioned this pull request Aug 25, 2022
@trajan0x trajan0x merged commit 0e1201b into master Aug 25, 2022
@trajan0x trajan0x deleted the go/make-anypath branch August 25, 2022 16:03
@trajan0x trajan0x self-assigned this Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant