Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add generic manager to simplify typecasts #692

Merged
merged 5 commits into from
Mar 20, 2023
Merged

Conversation

trajan0x
Copy link
Contributor

@trajan0x trajan0x commented Mar 19, 2023

Switch typecast files to use generics

@github-actions github-actions bot added 2-reviewers go Pull requests that update Go code M-contracts Module: Contracts labels Mar 19, 2023
@codecov
Copy link

codecov bot commented Mar 19, 2023

Codecov Report

Patch coverage: 78.78788% and project coverage change: -0.04102 ⚠️

Comparison is base (eebe9ea) 44.12105% compared to head (93a3a8c) 44.08003%.

Additional details and impacted files
@@                 Coverage Diff                 @@
##              master        #692         +/-   ##
===================================================
- Coverage   44.12105%   44.08003%   -0.04102%     
===================================================
  Files            486         486                 
  Lines          40679       40583         -96     
  Branches         174         174                 
===================================================
- Hits           17948       17889         -59     
+ Misses         20622       20595         -27     
+ Partials        2109        2099         -10     
Flag Coverage Δ
agents 59.01156% <100.00000%> (-0.45273%) ⬇️
ethergo 43.92316% <0.00000%> (+0.12232%) ⬆️
explorer 44.13750% <100.00000%> (-0.15280%) ⬇️
omnirpc 64.23017% <ø> (+0.23328%) ⬆️
scribe 34.50114% <100.00000%> (+0.13432%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ethergo/manager/manager.go 60.22727% <0.00000%> (-5.20484%) ⬇️
agents/testutil/typecast.go 100.00000% <100.00000%> (ø)
...rvices/explorer/testutil/testcontracts/typecast.go 100.00000% <100.00000%> (ø)
services/explorer/testutil/typecast.go 100.00000% <100.00000%> (ø)
services/scribe/testutil/typecast.go 100.00000% <100.00000%> (ø)

... and 12 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions github-actions bot removed 2-reviewers M-contracts Module: Contracts labels Mar 19, 2023
@trajan0x trajan0x marked this pull request as ready for review March 20, 2023 16:48
@trajan0x trajan0x changed the title add generic manager add generic manager to simplify typecasts Mar 20, 2023
@trajan0x trajan0x merged commit 52d3fe9 into master Mar 20, 2023
@trajan0x trajan0x deleted the feat/generic-manager branch March 20, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant