GasFeePricingUpgradeable #158
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2378229420
💛 - Coveralls |
trajan0x
reviewed
May 21, 2022
|
|
||
| event ChainInfoUpdated(uint256 indexed chainId, uint256 gasTokenPrice, uint256 gasUnitPrice); | ||
|
|
||
| event MarkupsUpdated(uint256 markupGasDrop, uint256 markupGasUsage); |
There was a problem hiding this comment.
What's a markup (might want to be a little more verbose here)
- variable names should be more clear now - enforced alfabetical order of variables to avoid confusion - docs on the srtucts are more verbose - tests are updated to reflect the these changes
- wrong value was used to check for maxGasDrop - some values were not cast to uin256, resulting in overflows
|
More tests are needed, but the contracts should be pretty close to their final form. |
|
Closed in favor of #162 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will make
GasFeePricingupgradeable. It will also use messaging for cross-chain setups.Checklist