Deploy: FastBridgeRouter, Create2Factory

[ChiTimesChi]

Description

Fixes # (issue)

Checklist

• New Contracts have been tested
• Lint has been run
• I have checked my code and corrected any misspellings

Summary by CodeRabbit

• New Features
  • Integrated a new service called Scroll to enhance blockchain operations with multiple functionalities including token bridging, liquidity management, and token swapping across different chains.
• Documentation
  • Updated configuration instructions to support the new Scroll service.
• Refactor
  • Improved the reliability of router deployment retrieval in blockchain scripts.

[coderabbitai]

Walkthrough

The latest changes bring forth a comprehensive expansion for the Scroll service, encompassing new smart contracts, configurations, and script enhancements. These updates aim to bolster blockchain interactions, facilitating token swaps, liquidity operations, and cross-chain functionalities for a seamless experience across the Scroll ecosystem.

Changes

Files	Changes Summary
.env.example, foundry.toml	Added configurations for the Scroll service, including API endpoints, keys, and Etherscan URL.
deployments/scroll/.chainId	Introduced chain ID 534352 for the Scroll service.
deployments/scroll/... (JSON files)	Added various smart contracts for token swaps, liquidity calculations, bridge protocols, and Uniswap V3 interactions.
script/router/... (Solidity files)	Enhanced router scripts with new functions for improved deployment address retrieval and management.

Poem

🐇✨
In the realm of bits and bytes,
A rabbit dances under moonlit lights.
Scroll's magic weaves, connecting distant nodes,
Tokens flow, bridges unfold, in codes.
Cheers to chains intertwined,
A digital symphony, beautifully designed! 🌟🌉

---

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 7ff24d6 and f0442aa.

Files ignored due to path filters (2)

• script/configs/scroll/LinkedPool.RFQ.USDC.dot is excluded by !**/*.dot
• script/configs/scroll/LinkedPool.RFQ.USDC.svg is excluded by !**/*.svg

Files selected for processing (5)

• deployments/scroll/UniswapV3Module.Metavault.json (1 hunks)
• script/configs/scroll/LinkedPool.RFQ.USDC.dc.json (1 hunks)
• script/configs/scroll/UniswapV3Module.dc.json (1 hunks)
• test/router/linkedPool/LinkedPoolConfig.Integration.Scroll.USDC.t.sol (1 hunks)
• test/router/modules/pool/LinkedPool.UniswapV3.Integration.Scroll.t.sol (1 hunks)

Additional comments not posted (5)

script/configs/scroll/UniswapV3Module.dc.json (1)

1-6: The configuration for the Uniswap V3 module appears correctly formatted and includes valid Ethereum addresses. Ensure these addresses correspond to the correct contracts on the intended network.

script/configs/scroll/LinkedPool.RFQ.USDC.dc.json (1)

1-10: The configuration for the LinkedPool RFQ in USDC is well-structured and includes valid Ethereum addresses. Verify that the nodeIndex and poolModule are correctly set up for the intended functionality.

test/router/linkedPool/LinkedPoolConfig.Integration.Scroll.USDC.t.sol (1)

6-13: The test contract LinkedPoolConfigUSDCScrollTestFork is well-defined. Ensure that the constants SWAP_VALUE and MAX_PERCENT_DELTA are set appropriately for the intended test scenarios.

test/router/modules/pool/LinkedPool.UniswapV3.Integration.Scroll.t.sol (1)

8-47: The test contract LinkedPoolUniswapV3ModuleScrollTestFork is correctly set up with relevant constants and addresses. The deployment and configuration of the UniswapV3Module within the test are appropriate. Ensure that the addresses used (e.g., UNI_V3_ROUTER, UNI_V3_STATIC_QUOTER) are correct and point to the intended contracts on the Scroll network.

deployments/scroll/UniswapV3Module.Metavault.json (1)

1-188: The deployment configuration for the UniswapV3Module is comprehensive, including the contract address, constructor arguments, and a detailed ABI. Ensure that the constructor arguments (uniswapV3Router_ and uniswapV3StaticQuoter_) are correctly formatted and correspond to the intended addresses. The ABI should be verified to ensure it matches the deployed contract's functionality.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coveralls]

Pull Request Test Coverage Report for Build 8899394801

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 12.934%

---

Totals
Change from base Build 8485603958:	0.0%
Covered Lines:	664
Relevant Lines:	4684

---

💛 - Coveralls