Fix storybook (twentyhq#5334)

Fixing the last broken stories, tests should be back to green!
synapsenet-arena · May 8, 2024 · 863554b · 863554b
1 parent 770ee11
commit 863554b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/...ges/twenty-front/src/modules/object-metadata/components/ObjectMetadataItemsLoadEffect.tsx b/...ges/twenty-front/src/modules/object-metadata/components/ObjectMetadataItemsLoadEffect.tsx
@@ -13,7 +13,7 @@ export const ObjectMetadataItemsLoadEffect = () => {
   const currentUser = useRecoilValue(currentUserState);
   const currentWorkspace = useRecoilValue(currentWorkspaceState);
 
-  const { objectMetadataItems: newObjectMetadataItems } =
+  const { objectMetadataItems: newObjectMetadataItems, loading } =
     useFindManyObjectMetadataItems({
       skip: isUndefinedOrNull(currentUser),
     });
@@ -28,12 +28,16 @@ export const ObjectMetadataItemsLoadEffect = () => {
       currentWorkspace?.activationStatus !== 'active'
         ? getObjectMetadataItemsMock()
         : newObjectMetadataItems;
-    if (!isDeeplyEqual(objectMetadataItems, toSetObjectMetadataItems)) {
+    if (
+      !loading &&
+      !isDeeplyEqual(objectMetadataItems, toSetObjectMetadataItems)
+    ) {
       setObjectMetadataItems(toSetObjectMetadataItems);
     }
   }, [
     currentUser,
     currentWorkspace?.activationStatus,
+    loading,
     newObjectMetadataItems,
     objectMetadataItems,
     setObjectMetadataItems,

diff --git a/...ta-model/fields/forms/components/__stories__/SettingsDataModelFieldTypeSelect.stories.tsx b/...ta-model/fields/forms/components/__stories__/SettingsDataModelFieldTypeSelect.stories.tsx
@@ -3,6 +3,7 @@ import { expect, userEvent, within } from '@storybook/test';
 import { ComponentDecorator } from 'twenty-ui';
 
 import { FieldMetadataType } from '~/generated-metadata/graphql';
+import { FormProviderDecorator } from '~/testing/decorators/FormProviderDecorator';
 import { graphqlMocks } from '~/testing/graphqlMocks';
 
 import { SettingsDataModelFieldTypeSelect } from '../SettingsDataModelFieldTypeSelect';
@@ -11,7 +12,7 @@ const meta: Meta<typeof SettingsDataModelFieldTypeSelect> = {
   title:
     'Modules/Settings/DataModel/Fields/Forms/SettingsDataModelFieldTypeSelect',
   component: SettingsDataModelFieldTypeSelect,
-  decorators: [ComponentDecorator],
+  decorators: [FormProviderDecorator, ComponentDecorator],
   parameters: {
     container: { width: 512 },
     msw: graphqlMocks,
@@ -33,11 +34,11 @@ export const WithOpenSelect: Story = {
   play: async ({ canvasElement }) => {
     const canvas = within(canvasElement);
 
-    const inputField = await canvas.findByText('Text');
+    const inputField = await canvas.findByText('Unique ID');
 
     await userEvent.click(inputField);
 
-    const input = await canvas.findByText('Unique ID');
+    const input = await canvas.findByText('Text');
     await userEvent.click(input);
 
     await userEvent.click(inputField);