Skip to content

Commit

Permalink
Remove isMultiSelect feature flag (twentyhq#5280)
Browse files Browse the repository at this point in the history
As title

Co-authored-by: Thomas Trompette <thomast@twenty.com>
  • Loading branch information
thomtrp and Thomas Trompette committed May 3, 2024
1 parent 5285a42 commit a5a9e0e
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 16 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,4 @@ export type FeatureFlagKey =
| 'IS_QUICK_ACTIONS_ENABLED'
| 'IS_EVENT_OBJECT_ENABLED'
| 'IS_AIRTABLE_INTEGRATION_ENABLED'
| 'IS_POSTGRESQL_INTEGRATION_ENABLED'
| 'IS_MULTI_SELECT_ENABLED';
| 'IS_POSTGRESQL_INTEGRATION_ENABLED';
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ import { Section } from '@/ui/layout/section/components/Section';
import { Breadcrumb } from '@/ui/navigation/bread-crumb/components/Breadcrumb';
import { View } from '@/views/types/View';
import { ViewType } from '@/views/types/ViewType';
import { useIsFeatureEnabled } from '@/workspace/hooks/useIsFeatureEnabled';
import { FieldMetadataType } from '~/generated-metadata/graphql';
import { isUndefinedOrNull } from '~/utils/isUndefinedOrNull';

Expand All @@ -42,7 +41,6 @@ export const SettingsObjectNewFieldStep2 = () => {
const navigate = useNavigate();
const { objectSlug = '' } = useParams();
const { enqueueSnackBar } = useSnackBar();
const isMultiSelectEnabled = useIsFeatureEnabled('IS_MULTI_SELECT_ENABLED');

const {
findActiveObjectMetadataItemBySlug,
Expand Down Expand Up @@ -288,10 +286,6 @@ export const SettingsObjectNewFieldStep2 = () => {
FieldMetadataType.Uuid,
];

if (!isMultiSelectEnabled) {
excludedFieldTypes.push(FieldMetadataType.MultiSelect);
}

return (
<SubMenuTopBarContainer Icon={IconSettings} title="Settings">
<SettingsPageContainer>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,6 @@ export const seedFeatureFlags = async (
workspaceId: workspaceId,
value: true,
},
{
key: FeatureFlagKeys.IsMultiSelectEnabled,
workspaceId: workspaceId,
value: true,
},
{
key: FeatureFlagKeys.IsStripeIntegrationEnabled,
workspaceId: workspaceId,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ export enum FeatureFlagKeys {
IsAirtableIntegrationEnabled = 'IS_AIRTABLE_INTEGRATION_ENABLED',
IsPostgreSQLIntegrationEnabled = 'IS_POSTGRESQL_INTEGRATION_ENABLED',
IsStripeIntegrationEnabled = 'IS_STRIPE_INTEGRATION_ENABLED',
IsMultiSelectEnabled = 'IS_MULTI_SELECT_ENABLED',
}

@Entity({ name: 'featureFlag', schema: 'core' })
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ export class AddStandardIdCommand extends CommandRunner {
IS_EVENT_OBJECT_ENABLED: true,
IS_AIRTABLE_INTEGRATION_ENABLED: true,
IS_POSTGRESQL_INTEGRATION_ENABLED: true,
IS_MULTI_SELECT_ENABLED: false,
IS_STRIPE_INTEGRATION_ENABLED: false,
},
);
Expand All @@ -74,7 +73,6 @@ export class AddStandardIdCommand extends CommandRunner {
IS_EVENT_OBJECT_ENABLED: true,
IS_AIRTABLE_INTEGRATION_ENABLED: true,
IS_POSTGRESQL_INTEGRATION_ENABLED: true,
IS_MULTI_SELECT_ENABLED: false,
IS_STRIPE_INTEGRATION_ENABLED: false,
},
);
Expand Down

0 comments on commit a5a9e0e

Please sign in to comment.