Skip to content
This repository has been archived by the owner on Apr 4, 2020. It is now read-only.

Add validation component #10

Merged
merged 4 commits into from
Apr 22, 2015
Merged

Add validation component #10

merged 4 commits into from
Apr 22, 2015

Conversation

synbot
Copy link

@synbot synbot commented Apr 21, 2015

Acceptance Criteria

  1. Accepts a list of messages
  2. Accepts a boolean for triggered or passive state
  3. Can wrap any element
  4. Accepts argument to render messages before or after children
  5. Ability to render messages to other components

@natestormer natestormer added this to the Sprint Backlog milestone Apr 21, 2015
@natestormer
Copy link
Contributor Author

⚠️ blocked by #9

@synbot synbot added S-Blocked and removed S-Open labels Apr 21, 2015
@natestormer
Copy link
Contributor Author

⭕

@synbot synbot added S-Open and removed S-Blocked labels Apr 21, 2015
@natestormer natestormer self-assigned this Apr 21, 2015
@natestormer
Copy link
Contributor Author

Ⓜ️

@natestormer
Copy link
Contributor Author

🌟

@synbot synbot added S-Review and removed S-Open labels Apr 21, 2015
kylecesmat
kylecesmat reviewed Apr 21, 2015
View reviewed changes
components/form/validation/validation.jsx
messageContainerProps : null,
messages : null
};
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spacing

@kylecesmat
Copy link
Contributor

⁉️ just a few things to fix and then you can +1 it

@synbot synbot added S-Open and removed S-Review labels Apr 21, 2015
@natestormer
Copy link
Contributor Author

🌟 @kylecesmat

@synbot synbot added S-Review and removed S-Open labels Apr 22, 2015
@natestormer
Copy link
Contributor Author

👍

@synbot synbot removed the S-Review label Apr 22, 2015
natestormer added a commit that referenced this pull request Apr 22, 2015
@natestormer
Merge pull request #10 from synapsestudios/design/10-validation
9e13e5b 
Add validation component
@natestormer natestormer merged commit 9e13e5b into master Apr 22, 2015
@natestormer natestormer deleted the design/10-validation branch April 22, 2015 00:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@natestormer natestormer

Labels
S-Accepted T-Design
Projects
None yet
Milestone
Sprint ∞
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@synbot @natestormer @kylecesmat