Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set ~ to /sdcard/ ??? #20

Closed
jedie opened this issue May 28, 2014 · 10 comments
Closed

set ~ to /sdcard/ ??? #20

jedie opened this issue May 28, 2014 · 10 comments

Comments

@jedie
Copy link

jedie commented May 28, 2014

In my case ~ would be set to /data/data/com.nutomic.syncthingandroid

syncthing v0.8.11

@Nutomic
Copy link
Contributor

Nutomic commented May 28, 2014

I reverted that change, because it caused problems on gingerbread. I might do it so that it only applies on honeycomb and up, but I plan to do a native Android ui with a proper file picker, so it shouldn't matter then.

@YtvwlD
Copy link

YtvwlD commented May 30, 2014

Which problems would it cause on Gingerbread? (/sdcard is the internal storage - it refers to /storage/sdcard0 in more modern versions of Android - I don't know when it started, but it was at least in Froyo.)

And it wouldn't cause problems with ~/.config/:

dos.writeBytes(getApplicationInfo().dataDir + "/" + BINARY_NAME + " " +
"-home " + getApplicationInfo().dataDir + "\n");

(lines 133/134 in src/main/java/com/nutomic/syncthingandroid/syncthing/SyncthingService.java)

@Nutomic
Copy link
Contributor

Nutomic commented May 30, 2014

I have no idea what exactly the problem is, but I got 8 crash reports like this through play store:

com.nutomic.syncthingandroid.service.SyncthingService$NativeExecutionException: Syncthing binary returned error code 3
stdout:
stdout:
stdout: 19:11:45 FATAL: No home directory found - set $HOME (or the platform equivalent).
stdout:

at com.nutomic.syncthingandroid.service.SyncthingService$NativeSyncthingRunnable.run(SyncthingService.java:168)
at java.lang.Thread.run(Thread.java:1019)

But Gingerbread still doesn't work, see #18

@YtvwlD
Copy link

YtvwlD commented May 30, 2014

i would understand this as $HOME hasn't been set. As I remember /sdcard is available on Android. (I think as of 1.6, but surely as of 2.2.)

@Nutomic
Copy link
Contributor

Nutomic commented May 30, 2014

Right, but using the data folder fixed that error, so there must have been a problem with the path. I don't have a 2.3 device myself, so I can only guess what the problem is.

@YtvwlD
Copy link

YtvwlD commented May 30, 2014

Sadly (or happily), I don't have a 2.3 device either. (But I used to have one.) (And I used to have a 2.2 device.)

@Nutomic
Copy link
Contributor

Nutomic commented May 30, 2014

I had an HTC Desire running cm7 (and all kinds of roms before that). But that doesn't really help now :P

@YtvwlD
Copy link

YtvwlD commented Jun 8, 2014

Well, this happens for Honeycomb, too (see #30).

@Nutomic
Copy link
Contributor

Nutomic commented Jun 8, 2014

ICS+ makes up about 97% of users according to the Play Store (with a single Honeycomb device), so this hasn't been so apparent yet. Great to get it finally fixed :)

stats

@Nutomic
Copy link
Contributor

Nutomic commented Jun 27, 2014

I implemented a file browser, so you won't have to type in the path any more.

It will be in 0.4.0.

@Nutomic Nutomic closed this as completed Jun 27, 2014
@syncthing syncthing locked and limited conversation to collaborators Nov 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants