Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPE in SettingsFragment onApiChange #328

Closed
Zillode opened this issue Mar 30, 2015 · 2 comments
Closed

NPE in SettingsFragment onApiChange #328

Zillode opened this issue Mar 30, 2015 · 2 comments
Labels
bug frozen-due-to-age

Comments

@Zillode
Copy link
Contributor

Zillode commented Mar 30, 2015 

java.lang.NullPointerException
at com.nutomic.syncthingandroid.fragments.SettingsFragment.onApiChange(SettingsFragment.java:58)
at com.nutomic.syncthingandroid.syncthing.SyncthingService.registerOnApiChangeListener(SyncthingService.java:366)
at com.nutomic.syncthingandroid.fragments.SettingsFragment.onServiceConnected(SettingsFragment.java:151)
at com.nutomic.syncthingandroid.activities.SyncthingActivity.onServiceConnected(SyncthingActivity.java:52)
at android.app.LoadedApk$ServiceDispatcher.doConnected(LoadedApk.java:1131)
at android.app.LoadedApk$ServiceDispatcher$RunConnection.run(LoadedApk.java:1148)
at android.os.Handler.handleCallback(Handler.java:800)
at android.os.Handler.dispatchMessage(Handler.java:100)
at android.os.Looper.loop(Looper.java:194)
at android.app.ActivityThread.main(ActivityThread.java:5371)
at java.lang.reflect.Method.invokeNative(Native Method)
at java.lang.reflect.Method.invoke(Method.java:525)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:833)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:600)
at de.robv.android.xposed.XposedBridge.main(XposedBridge.java:132)
at dalvik.system.NativeStart.main(Native Method)
@Zillode Zillode added the bug label Mar 30, 2015
@Zillode
Copy link
Contributor Author

Zillode commented Apr 5, 2015

Related

java.lang.NullPointerException
at com.nutomic.syncthingandroid.fragments.DeviceSettingsFragment.onReceiveConnections(DeviceSettingsFragment.java:278)
at com.nutomic.syncthingandroid.syncthing.RestApi$8.onPostExecute(RestApi.java:565)
at com.nutomic.syncthingandroid.syncthing.RestApi$8.onPostExecute(RestApi.java:556)
at android.os.AsyncTask.finish(AsyncTask.java:632)
at android.os.AsyncTask.access$600(AsyncTask.java:177)
at android.os.AsyncTask$InternalHandler.handleMessage(AsyncTask.java:645)
at android.os.Handler.dispatchMessage(Handler.java:102)
at android.os.Looper.loop(Looper.java:136)
at android.app.ActivityThread.main(ActivityThread.java:5146)
at java.lang.reflect.Method.invokeNative(Native Method)
at java.lang.reflect.Method.invoke(Method.java:515)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:732)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:566)
at dalvik.system.NativeStart.main(Native Method)

Nutomic pushed a commit that referenced this issue Apr 24, 2015
wip (fixes #328).
062b84d 
This makes sure listeners are not invoked after being destroyed.
@Nutomic
Copy link
Contributor

Nutomic commented Apr 24, 2015

The second one is probably fixed by the (mVersion == null || mCurrentAddress == null) check you added there.

This should help with the first.

Zillode pushed a commit to Zillode/syncthing-android that referenced this issue Apr 25, 2015
@Nutomic @Zillode
Do not use WeakReference for listeners (fixes syncthing#328).
b754bc6 
This makes sure listeners are not invoked after being destroyed.

Also call onApiChange() on GUI thread.

Conflicts:
	src/main/java/com/nutomic/syncthingandroid/syncthing/SyncthingService.java
@syncthing syncthing locked and limited conversation to collaborators Nov 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Zillode @Nutomic @st-review