Update dependency resolution management #2000
Conversation
|
What's the reason for switching the style/syntax? Not that I have any strong preferences, but the existing one I have already seen/used and the new one not at all, so I'd like to hear about some incentives for the switch :) There are also a few other build.gradle files, and I'd like to have a single syntax/style everywhere. |
## Description Back in 2021 [JFrog announced](https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/) that they are deprecating the JCenter repository. It's still read-only but it shouldn't be depended upon. I was trying to remove it in the other PR: #2000, but then I found out a single dependency still needs it: [libsuperuser](https://github.com/Chainfire/libsuperuser). The most "up to date" version [can be found in JitPack](https://jitpack.io/#Chainfire/libsuperuser). I had to update the version manually as dependabot would never pick it up until JitPack is added to the list of repositories. ## Changes * add the JitPack as a new repository to the project * update the `libsuperuser` dependency to version `1.1.1`
Those files were using Groovy language and they were refactored to use Kotlin DSL. I'd happily refactor the other remaining |
adamszewe
force-pushed
the
update-dependency-resolution-management
branch
from
eb3608e
to
af2a919
Compare
|
Thanks for explaining - this being the new default is particularly convincing to me :) Please do change all of them, I'd like to use one style/DSL only throughout the project. |
|
I opened a new PR that completes this refactor: #2022 |
## Description: Refactor gradle build files to use Kotlin DSL instead of Groovy. There were also a bash script and a python script that needed to be updated because they relied on parsing the `build.gradle` files written in Groovy. This PR completes the work started in: #2000
adamszewe
force-pushed
the
update-dependency-resolution-management
branch
from
af2a919
to
92b6ba8
Compare
|
@imsodin I rebased the PR to get latest updates and this PR is ready to review |
| repositories { | ||
| gradlePluginPortal() | ||
| google() | ||
| jcenter() | ||
| mavenCentral() | ||
| } |
There was a problem hiding this comment.
Just to double check: This block needs to be present both here and in settings.gradle.kts?
There was a problem hiding this comment.
Yes, it still has to be present because the buildscript block is used.
If it's removed the build fails as it cannot resolve those dependencies in the buildscript.
It should be possible to get rid of this, I'll try to do that in a future PR.
There was a problem hiding this comment.
Oh no worries, just wanted to make sure this wasn't a simple oversight
Changes
build.gradleandsettings.gradlefrom Groovy syntax to Kotlin DSL (thus replacing those files withbuild.gradle.ktsandsettings.gradle.ktsrespectively)The remaining
build.gradlefiles are refactored in: #2022