Upgrade Gradle wrapper to version 8.5
#2021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamszewe
force-pushed
the
upgrade-gradle-wrapper
branch
from
ff0a88f
to
7cb37fa
Compare
adamszewe
force-pushed
the
upgrade-gradle-wrapper
branch
from
7cb37fa
to
8884bbe
Compare
adamszewe
commented
Jan 5, 2024
| tasks.named("mergeReleaseJniLibFolders") { | ||
| dependsOn(":syncthing:buildNative") | ||
| } | ||
| } |
There was a problem hiding this comment.
Newer versions of Gradle check for implicit dependencies between tasks.
With an implicit dependency the build fails as follows:
The above change makes the dependency explicit.
…eleaseJniLibFolders
adamszewe
force-pushed
the
upgrade-gradle-wrapper
branch
from
8884bbe
to
1937a3b
Compare
imsodin
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dependabot does not support (yet) upgrading the Gradle wrapper thus it needs to be updated/upgraded manually.
Changes:
8.5See also: dependabot/dependabot-core#2223