Add local discovery to select device id during the setup

[l-jonas]

No description provided.

[Nutomic]

Cool! But please make sure your lines aren't too long. I think I used a maximum of 100 characters per line.

[l-jonas]

@Nutomic

I reduced the line length, but there are already some lines with more than 100 chars (so a lint rule for that is not possible)

BTW: Before creating a new release of this, it would be a good idea to release a new version of https://github.com/syncthing/syncthing-java and update the dependency of this project on it (the CI always uses the master of syncthing-java so that it works, but someone else probably does not) because it uses an API which I added there.

[Nutomic]

Yeah I'm aware of updating the library. For a release, I think the main issues to fix first are #6 and #12. Are those resolved for you? (I will also give it a try tomorrow).

[l-jonas]

@Nutomic Well, for me it "works".

What I observed (didn't analyzed it yet, started testing with the current F-Droid built so it can be that it only happens there):

• sometimes the App crashes after the setup
• sometimes downloads do not work (do not start or hang randomly)
• sometimes new files do not show up, restarting the App helps
• the global discovery does not work (fixed by the library update)

However, the global discovery still does not work (at the internet access I use now) because the java client wants to use my public IP and not the relay server but I think that this is caused by my strange setup (2 routers chained so the port forwarding likely is executed by the inner one so that Syncthing at my Computer thinks it's reachable over the Internet). Still, the non-lite Android Client works in that situation over the relay server, so I think it tries all routes.

I looked futher at this and pingAddresses() at net.syncthing.java.discovery.utils.AddressRanker seems to be relevant. It only checks if it can connect and does not try to establish a session. This could explain #6

[Nutomic]

Yeah there's definitely a bunch of problems with connections etc, I don't remember them exactly. But if you can reliably connect to devices and transfer files, that would be a huge progress.