-
Notifications
You must be signed in to change notification settings - Fork 22
Conversation
- multiple coroutine versions (ProGuard did not like it) - crashes due to obfuscation of specific coroutine code
Okay some things I noticed:
|
To the "another syncthing instance is running" warning: This is not good. I created an issue for it at #62. To the reconnect warning: I used the term WiFi because most people understand it better than "local network" or "local connections". But I'm not sure about the audience of syncthing lite. To the server offline handling: It would be possible to save that one connecting attempt has been made already to fail early (without trying to connect again). And the error message could be better when the server was not reached. I created an issue at #63 To the failing downloading:
|
I think the error is misleading, because when I connect to my remote server, it is also a "connection over wifi". And I think it makes sense if we use terms that are consistent with Syncthing. And I will give that a try later :) |
Okay it works fine after increasing the timeout to 60 seconds 👍 By the way, seeing x/1000 looks weird, I would really go with x/100. |
The dialog is replaced by a message which is shown at the bottom of the introduction screen and the folder list. This fixes #62
The things were changed (except the server offline handling as this is more complex) |
Much better, thanks! Now you can just make a commit to master with the new versionName and versionCode, and tag it. |
@Nutomic I created an release build (which contains this) and verified that it works. For the releasing, I would prefer if someone else (e.g. you) would test it too because broken builds are very bad (this applies to all releases, not just this one).