Skip to content
This repository has been archived by the owner on Apr 17, 2020. It is now read-only.

Bugfixes #61

Merged
merged 6 commits into from
Oct 23, 2018
Merged

Bugfixes #61

merged 6 commits into from
Oct 23, 2018

Conversation

l-jonas
Copy link

@l-jonas l-jonas commented Oct 18, 2018

@Nutomic I created an release build (which contains this) and verified that it works. For the releasing, I would prefer if someone else (e.g. you) would test it too because broken builds are very bad (this applies to all releases, not just this one).

- multiple coroutine versions (ProGuard did not like it)
- crashes due to obfuscation of specific coroutine code
@Nutomic
Copy link

Nutomic commented Oct 19, 2018

Okay some things I noticed:

  • The dialog "Another Syncthing instance is running" pops up every time you click on a folder, and every time you go back to the main Activity. Ideally it should only show up once on app start, and maybe have a checkbox/setting "don't show this again".
  • The string dialog_warning_reconnect_problem is a bit unclear, instead of "connections over wifi" you should say something like "local discovery connections" or "local connections". And maybe try to shorten the entire message.
  • If the remote device is disconnected, you can still open a folder, and try to download a file. The app shows a "Downloading" dialog and then fails after a few seconds. That should be handled earlier (but not necessarily in this release).
  • Connecting to a remote device was pretty slow to me and ifle downloads failed, but that's probably because my internet connection is really bad, and the test server is really far away.

@l-jonas
Copy link
Author

l-jonas commented Oct 20, 2018

@Nutomic

To the "another syncthing instance is running" warning:

This is not good. I created an issue for it at #62.

To the reconnect warning:

I used the term WiFi because most people understand it better than "local network" or "local connections". But I'm not sure about the audience of syncthing lite.

To the server offline handling:

It would be possible to save that one connecting attempt has been made already to fail early (without trying to connect again). And the error message could be better when the server was not reached. I created an issue at #63

To the failing downloading:

@Nutomic
Copy link

Nutomic commented Oct 20, 2018

I think the error is misleading, because when I connect to my remote server, it is also a "connection over wifi". And I think it makes sense if we use terms that are consistent with Syncthing.

And I will give that a try later :)

@Nutomic
Copy link

Nutomic commented Oct 21, 2018

Okay it works fine after increasing the timeout to 60 seconds 👍

By the way, seeing x/1000 looks weird, I would really go with x/100.

The dialog is replaced by a message which is shown at the bottom of the introduction screen and the folder list.

This fixes #62
@l-jonas
Copy link
Author

l-jonas commented Oct 21, 2018

The things were changed (except the server offline handling as this is more complex)

@Nutomic Nutomic merged commit 7bdcef8 into syncthing:master Oct 23, 2018
@Nutomic
Copy link

Nutomic commented Oct 23, 2018

Much better, thanks!

Now you can just make a commit to master with the new versionName and versionCode, and tag it.

@l-jonas l-jonas deleted the bugfixes branch October 23, 2018 11:16
@syncthing syncthing locked and limited conversation to collaborators Oct 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants