-
-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brew caskroom #23
Comments
I'm using caskroom for some applications, it would be nice to have syncthing-macosx indexed. Keep in mind the upgrade mechanism of the OSX GUI is done with Sparkle (github releases) and is separate from the syncthing updater and caskroom updater. |
Why this would be a problem? I know that its just matter of one instal and then your client keeps itself up to date. The thing is Caskroom cant update aplications anyway (not yet anyway). It also used to be not very good but now its much better. I see caskroom more like convenience when you format your computer and you do first time batch install of open-source apps through shell script. |
It is no problem, but people should keep that in mind. I totally agree with your comment. |
I can't find it with cask search so I guess this was never done? |
Thats right, no brew is available yet. |
I gave it some time but honestly lost interest quickly since it wasnt that straightforward and it updates itself. Sorry. |
That's no problem, both syncthing-macosx (sparkle) and syncthing (upgrade server) itself update when updates are pushed. |
Thanks guys for the report, I'm not going to support this distribution channel. As syncthing and syncthing-macosx have their own stable upgrade/install channel. I'm closing this but feel free to comment. |
Please reconsider this, You do not have to update the cask on new releases if the app already has the ability to upgrade itself, still for initial installation brew is the right way. |
Other people are free to add it to brew. But it won't be initiated from the syncthing-macosx project. |
I've just created a cask for |
@fturcheti thanks for your effort. I have added it to the readme (as seen in the commit above). |
* Fixup project move leftovers and update some documentation and contributing * Cleanup xcode project with useless xgsyncthing target * README.md: Add note about homebrew cask (ref #23)
* syncthing/Scripts/syncthing-resource.sh: Bundle with 0.14.47 * Get rid of syncthing/Scripts/syncthing-inotify-resource.sh as filesystem change notifications are builtin to syncthing since v0.14.47 * Delay reconnect attempts if the server returned an error (#47) This should fix high CPU usage issue when API key is invalid. Partial fixes #46. * Bump syncthing resource to v0.14.48 (#55) * syncthing/STApplication.m: Sort folders submenu ascending (fixes #49) (#53) * syncthing/STApplication.m: Sort folders submenu ascending (fixes #49) * syncthing/STApplication.m: Fix review comment of @virusman * Use CocoaPods for Sparkle framework dependency (fixes #57) (#60) * Update syncthing resource to v0.14.49 (#64) * Update syncthing resource to v0.14.49 * syncthing/Scripts/syncthing-resource.sh: Use new tarball name * Adjust event request timeout (fixes #65) (#66) This sets the event request a bit longer and, more importantly, informs Syncthing of the timeout. The result is that the request returns successfully without events, and we don't get a timeout error. * Refactor HTTP(S) handling (fixes #24) This moves event getting into the XGSyncthing library, while also refactoring it to use NSURLSession, a delegate for allowing local TLS certificates, and proper parameters. The delegate simply skips HTTPS certificate checking on hosts called "localhost", "127.0.0.1", or "::1". I think this is what most people would want from this tool. * Remove #24 from README too * README.md: Update to use new URLs (#67) Also add @calmh to AUTHORS.md * Move LocalhostTLSDelegate files accidentally committed at root (#70) * Generate appcast.xml from github releases (#63) * script/ghreleases2appcast.go: Initial working github releases to sparkle framework appcast.xml converter (resolves #62) * Activate existing windows for About/Preferences (fixes #72) (#73) * Add daemon process handling (fixes #48) (#71) * Add new submenu with status of the syncthing service * Cleanup some code * Copy executable from bundle (fixes #37) (#76) This copies the bundled executable before executing it, if the target executable doesn't already exist. This has several desirable properties: - We do not mess up the application bundle by letting Syncthing upgrade - The user can revert an undesired upgrade by deleting the binary and restarting the wrapper. The binary is stored in ~/Application Support/Syncthing-macOS because I don't want to put it in Syncthing's config directory. That directory is in principle managed by Syncthing and we can't be sure it won't be removed or something. * Prepare for v0.14.49-1 release (#75) * syncthing.xcodeproj/project.pbxproj: Rename PRODUCT_BUNDLE_IDENTIFIER for Sparkle updater (see #74) (#79) From com.github.syncthing.syncthing-macos back to com.github.xor-gate.syncthing-macosx to fix Sparkle update issue in #74. * script/ghreleases2appcast.go: Use working blackfriday.v1 (see #77) (#78) * script/ghreleases2appcast.go: Changes for upgrades.s.n deployment (#80) Basically, don't alter the download URLs for now, indent the XML for readability. * Fixup project move leftovers and update some documentation (#81) * Fixup project move leftovers and update some documentation and contributing * Cleanup xcode project with useless xgsyncthing target * README.md: Add note about homebrew cask (ref #23) * readme: Update contribution guidelines link (fixes #83) * Bump syncthing resource to 0.14.50 * Use latest syncthing v0.14.51 resource * CocoaPods: Manual patch EXPANDED_CODE_SIGN_IDENTITY: unbound variable #7708 bug * Use syncthing v0.14.52 resource
Since this is best syncthing client wrapper for osx i think it should be in caskroom. Its used by more and more people.
Ive never made cask (https://github.com/caskroom/homebrew-cask/blob/master/doc/development/adding_a_cask.md) but i guess there is nobody who has experience with that (or uses caskroom) i will have to make it somehow.
Putting it here just for lovely someone who made cask before and could do it more easily :))
The text was updated successfully, but these errors were encountered: