syncthing/STApplication.m: Sort folders submenu ascending (fixes #49) #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virusman
reviewed
Jul 3, 2018
| @@ -163,7 +163,13 @@ - (IBAction) clickedOpen:(id)sender { | |||
| - (void) updateFoldersMenu:(NSMenu *)menu { | |||
| [menu removeAllItems]; | |||
|
|
|||
| for (id dir in [self.syncthing getFolders]) { | |||
| // Get folders from syncthing and sort ascending | |||
| NSSortDescriptor *sort = [NSSortDescriptor sortDescriptorWithKey:@"label" ascending:YES comparator:^NSComparisonResult(id obj1, id obj2) { | |||
There was a problem hiding this comment.
It should work without a comparator. NSSortDescriptor defaults to compare: anyway.
| NSSortDescriptor *sort = [NSSortDescriptor sortDescriptorWithKey:@"label" ascending:YES comparator:^NSComparisonResult(id obj1, id obj2) { | ||
| return [(NSString *)obj1 compare:(NSString *)obj2 options:NSNumericSearch]; | ||
| }]; | ||
| NSArray *folders = [[self.syncthing getFolders] sortedArrayUsingDescriptors:[NSArray arrayWithObject:sort]]; |
There was a problem hiding this comment.
arrayWithObject: can be replaced with just @[sort].
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR is deprecated in favor of #53. I made the decision we need a master, and develop branch.