Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joining relay session (BEP/relay): Incorrect response code 1: not found #3272

Closed
andrewufrank opened this issue Jun 7, 2016 · 11 comments
Closed
Labels
frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion

Comments

@andrewufrank
Copy link

andrewufrank commented Jun 7, 2016

running 13.4. i see regularly the error message
Joining relay session (BEP/relay): Incorrect response code 1: not found

or
Joining relay session (BEP/relay): Incorrect response code 2: already connected

It appears since moving to 13, i never saw it running 12.x before.

what is the cause? what can be done to fix it?
thank you!

@AudriusButkevicius
Copy link
Member

Do you know which relay that happens with?

@calmh
Copy link
Member

calmh commented Jun 7, 2016

I guess this is when the discovery server says a device is connected to a certain relay, but they are in fact not? We only remove those entries by time out, which can be a while I think?

@AudriusButkevicius
Copy link
Member

I'd have to check the code, but this is joining the session, rather than getting an invitation.

@andrewufrank
Copy link
Author

i find in the syslog:
Jun 7 10:01:45 almeria syncthing[11419]: [xxx] WARNING: Joining relay session (BEP/relay): Incorrect response code 1: not found Jun 7 10:01:45 almeria syncthing[11419]: [xxx] INFO: Disconnected from relay relay://195.154.113.77:22067 Jun 7 10:01:46 almeria syncthing[11419]: [xxx] INFO: Joined relay relay://134.119.8.239:22067
does this help?

@scienmind
Copy link
Contributor

The same story as I discussed here here: https://forum.syncthing.net/t/using-relays-periodically-generates-notice-messages/7550/9.

I still think there is more to it then just "one especially bad internet connection"...

@AudriusButkevicius
Copy link
Member

This is something elset though. I need to look at the code not from the phone though

@scienmind
Copy link
Contributor

scienmind commented Jun 7, 2016

The Joining relay session (BEP/relay): Incorrect response code 2: already connected I talked about in the forum is the most frequent one, but occasionally, since v.0.13 I'm getting those as well:
Joining relay session (BEP/relay): EOF
Joining relay session (BEP/relay): Incorrect response code 1: not found
Joining relay session (BEP/relay): Incorrect response code 2: already connected
Joining relay session (BEP/relay): dial tcp P:PORT: connectex: An established connection was aborted by the software in your host machine.
Joining relay session (BEP/relay): dial tcp IP:PORT: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.

@AudriusButkevicius
Copy link
Member

All of them apart from the second one is a sign of shit internet.

@AudriusButkevicius
Copy link
Member

So already connected can happen if both sides happen to connect at virtually the same time, and the relay happens to be running on a weak machines. Essentially this:
https://github.com/syncthing/syncthing/blob/master/cmd/relaysrv/session.go#L125
default case should be replaced with some sort of timeout.

The not found can potentially be caused by a misconfigured relay with a very short session timeout or a slow connecting node, which happens to take a while (long while) to connect to the relay, by which time the session has already timed out.

I do not think any of these are fatal, and should resolve themselves in 10 or so minutes.

I do not think there was any fundamental behavioural changes in 0.13 that could potentially be to blame, yet the network the relays has expanded quite a lot recently, potentially on-boarding funky relays which cause these things that you observe.

@andrewufrank
Copy link
Author

thank you for your very instructive explanation indicating that i need not worry (except for the quality of my internet provider, but there is limited choice). in general, it would be best if the GUI shows only information which needs action by the user and perhaps even indicates what should be done.

@AudriusButkevicius
Copy link
Member

AudriusButkevicius commented Jun 8, 2016

This was already addressed by @scienmind and will be in the next release

@st-review st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label Jun 16, 2017
@syncthing syncthing locked and limited conversation to collaborators Jun 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion
Projects
None yet
Development

No branches or pull requests

5 participants