Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/syncthing: Extra parameters on command line should trigger failure and usage message #3690

Closed
dinosore opened this issue Oct 26, 2016 · 1 comment
Closed

cmd/syncthing: Extra parameters on command line should trigger failure and usage message #3690

dinosore opened this issue Oct 26, 2016 · 1 comment
Labels
bug A problem with current functionality, as opposed to missing functionality (enhancement) frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion

Comments

@dinosore
Copy link
Contributor

For some unknown reason, I entered syncthing /paths instead of syncthing -paths at the command line for a user not currently running syncthing.

It seems that st ignores any arguments other than options, and started normally, creating files and certificates and launching the gui.

Options appear to be validated as expected. syncthing -paths and syncthing --paths are accepted and show the expected information. syncthing ---paths and syncthing -junk respond as syncthing -help.

However, there seems to be no validation that the rest of the command line is empty apart from comments.

No great harm happened - just a few files to delete.

I consider this a minor, embarrassing bug.

Version Information

Syncthing Version: v0.14.9
OS Version: Debian stretch...
Browser Version: n/a
@calmh
Copy link
Member

calmh commented Oct 26, 2016

Yeah, should trigger the usage message.

@calmh calmh added the bug A problem with current functionality, as opposed to missing functionality (enhancement) label Oct 26, 2016
@calmh calmh added this to the Unplanned (Contributions Welcome) milestone Oct 26, 2016
@dinosore dinosore changed the title Fail on unidentified input on command line. (bug or feature?) Doesn't fail on unidentified input on command line Oct 26, 2016
@calmh calmh changed the title Doesn't fail on unidentified input on command line cmd/syncthing: Extra parameters on command line should trigger failure and usage message Nov 23, 2016
@rumpelsepp rumpelsepp mentioned this issue Nov 27, 2016
Closed
@st-review st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label Nov 28, 2017
@syncthing syncthing locked and limited conversation to collaborators Nov 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug A problem with current functionality, as opposed to missing functionality (enhancement) frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmd/syncthing: Trigger usage message on extra CLI parameters
3 participants
@calmh @dinosore @st-review