Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parallel dial doesn't dial all addresses #4526

Closed
calmh opened this issue Nov 19, 2017 · 0 comments
Closed

Parallel dial doesn't dial all addresses #4526

calmh opened this issue Nov 19, 2017 · 0 comments
Assignees
@calmh
Labels
bug A problem with current functionality, as opposed to missing functionality (enhancement) frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion skip-changelog Bugs that have never been in a released stable version, and as such excluded from the release notes

Comments

@calmh
Copy link
Member

calmh commented Nov 19, 2017 

[JWK46] 2017/11/19 10:51:49.360294 service.go:343: DEBUG: Reconnect loop for AGR6NY2
[JWK46] 2017/11/19 10:51:51.467874 service.go:365: DEBUG: Not dialing relay://163.172.179.61:8443/?id=FU55S7D-DO2JQEP-DYE6SLV-UKU4FS2-BMDTHUE-L5633N2-CIFX32Y-QQUVQAC&pingInterval=1m0s&networkTimeout=2m0s&sessionLimitBps=0&globalLimitBps=0&statusAddr=:22070&providedBy=harry.lu - Paris2, FR as sleep is 1m0s, next dial is at 2017-11-19 10:59:28.23293814 +0100 CET m=+830.558230924 and current time is 2017-11-19 10:51:49.359790965 +0100 CET m=+371.685083819
[JWK46] 2017/11/19 10:51:51.468402 service.go:365: DEBUG: Not dialing tcp://192.168.1.10:22000 as sleep is 1m0s, next dial is at 2017-11-19 10:52:49.359790965 +0100 CET m=+431.685083819 and current time is 2017-11-19 10:51:49.359790965 +0100 CET m=+371.685083819
[JWK46] 2017/11/19 10:51:51.469057 structs.go:189: DEBUG: dialing AGR6NY2 tcp://85.216.59.171:22000 prio 10
[JWK46] 2017/11/19 10:51:51.469906 structs.go:189: DEBUG: dialing AGR6NY2 tcp://85.216.59.171:22000 prio 10
[JWK46] 2017/11/19 10:52:01.470134 structs.go:191: DEBUG: dialing AGR6NY2 tcp://85.216.59.171:22000 outcome %!v(PANIC=runtime error: invalid memory address or nil pointer dereference) dial tcp 85.216.59.171:22000: i/o timeout
[JWK46] 2017/11/19 10:52:01.471001 structs.go:191: DEBUG: dialing AGR6NY2 tcp://85.216.59.171:22000 outcome %!v(PANIC=runtime error: invalid memory address or nil pointer dereference) dial tcp 85.216.59.171:22000: i/o timeout
[JWK46] 2017/11/19 10:52:01.471526 service.go:781: DEBUG: failed to connect to AGR6NY2 10

Note it filtering out one address, then dialling tcp://85.216.59.171:22000 apparently twice. There is a race in the parallel dialler.
@calmh calmh added bug A problem with current functionality, as opposed to missing functionality (enhancement) skip-changelog Bugs that have never been in a released stable version, and as such excluded from the release notes labels Nov 19, 2017
@calmh calmh self-assigned this Nov 19, 2017
calmh added a commit to calmh/syncthing that referenced this issue Nov 19, 2017
@calmh
lib/connections: Fix race condition in parallel dial, minor cleanups (f…
b471236 
…ixes syncthing#4526)
calmh added a commit that referenced this issue Nov 19, 2017
@calmh
lib/connections: Fix race condition in parallel dial, minor cleanups (f…
3312a29 
…ixes #4526)
calmh added a commit that referenced this issue Nov 20, 2017
@calmh
Merge branch 'release'
8078bab 
* release:
  build: Windows code signing (ref #3420)
  lib/connections: Fix race condition in parallel dial, minor cleanups (fixes #4526)
@calmh calmh modified the milestone: v0.14.41 Dec 3, 2017
@st-review st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label Nov 20, 2018
@syncthing syncthing locked and limited conversation to collaborators Nov 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@calmh calmh

Labels
bug A problem with current functionality, as opposed to missing functionality (enhancement) frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion skip-changelog Bugs that have never been in a released stable version, and as such excluded from the release notes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@calmh @st-review