Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date selector dialog on restore versions partially hidden #4755

Open
moorcito opened this issue Feb 13, 2018 · 4 comments
Open

Date selector dialog on restore versions partially hidden #4755

moorcito opened this issue Feb 13, 2018 · 4 comments
Labels
bug A problem with current functionality, as opposed to missing functionality (enhancement)

Comments

@moorcito
Copy link

- What happened

Clicked on Versions > Filter by date and tried to set a time range. This is what I saw.

screenshot from 2018-02-13 10-59-32

The top of the dialog box is obscured by the address bar. This also happens in chromium.

- What operating system, operating system version and version of Syncthing you are running

Syncthing v0.14.45-rc.1, FreeBSD (64 bit)
Firefox 58.0.2 (64-bit)
Chromium Version 64.0.3282.140 (Official Build) Built on Ubuntu , running on Ubuntu 17.10 (64-bit)

@AudriusButkevicius
Copy link
Member

Yeah, it's not a mobile friendly UI, but there is nothing we can do sadly, uness some CSS guru wants to step up and fix this.

@AudriusButkevicius AudriusButkevicius added the bug A problem with current functionality, as opposed to missing functionality (enhancement) label Feb 13, 2018
@AudriusButkevicius AudriusButkevicius changed the title Date selector dialog on restore option partially hidden Date selector dialog on restore versions partially hidden Feb 13, 2018
@uok
Copy link
Contributor

uok commented Feb 13, 2018

my workaround: expand the folder/file tree which gives the page some vertical content and then select filter

tomasz1986 added a commit to tomasz1986/syncthing that referenced this issue Feb 20, 2021
…thing#4755, fixes syncthing#5408)

Change the position of the calendar popup to the bottom, so that it does
not go outside of the screen. Fix the date values, so that the default
range covers all possible time, and it is possible to either enter the
values manually in the input field, or to use the picker to choose the
start and end dates.

Signed-off-by: Tomasz Wilczyński <twilczynski@naver.com>
tomasz1986 added a commit to tomasz1986/syncthing that referenced this issue Feb 20, 2021
…thing#4755)

Change the position of the calendar popup to the bottom, so that it does
not go outside of the screen. This way, even on small phone screens, we
should be possible to simply scroll down to view the whole popup.

Signed-off-by: Tomasz Wilczyński <twilczynski@naver.com>
tomasz1986 added a commit to tomasz1986/syncthing that referenced this issue Feb 21, 2021
Change the position and the parent element of the calendar popup, so
that it spawns inside the Restore Versions modal. This way, even on
small phone screens it is possible to scroll down to view the whole
calendar.

Signed-off-by: Tomasz Wilczyński <twilczynski@naver.com>
@isavcic
Copy link

isavcic commented Apr 7, 2021

Still an issue. OS X Catalina on Retina, in Firefox and Safari both.

@AudriusButkevicius
Copy link
Member

Yes, this issue is still open.

tomasz1986 added a commit to tomasz1986/syncthing that referenced this issue Sep 24, 2021
…cthing#4755)

Add various tweaks to the Restore Versions modal in order to make it
more usable in general, and also to prevent the content from breaking
when used with long filenames and on small resolutions.

The specific changes are as follows.

1. Contain the file list in a resizable box, which by defaults occupies
   as much space as needed without overflowing the screen vertically.
   This prevents the whole body from being pushed down by the list, and
   also keeps the filter and confirmation buttons visible on the screen.
2. Forcefully break long filenames with no spaces, so that they always
   fit on the screen.
3. Change the position of the restore buttons' menu popup to the left,
   so that it does not go out of the screen on small resolutions.
4. Widen the filter input fields, so that there is more space for the
   text, and especially the data range fits without being cut off.

Signed-off-by: Tomasz Wilczyński <twilczynski@naver.com>
tomasz1986 added a commit to tomasz1986/syncthing that referenced this issue Sep 24, 2021
…cthing#4755)

Add various tweaks to the Restore Versions modal in order to make it
more usable in general, and also to prevent the content from breaking
when used with long filenames and on small resolutions.

The specific changes are as follows.

1. Contain the file list in a resizable box, which by defaults occupies
   as much space as needed without overflowing the screen vertically.
   This prevents the whole body from being pushed down by the list, and
   also keeps the filter and confirmation buttons visible on the screen.
2. Forcefully break long filenames with no spaces, so that they always
   fit on the screen.
3. Change the position of the restore buttons' menu popup to the left,
   so that it does not go out of the screen on small resolutions.
4. Widen the filter input fields, so that there is more space for the
   text, and especially the data range fits without being cut off.

Signed-off-by: Tomasz Wilczyński <twilczynski@naver.com>
tomasz1986 added a commit to tomasz1986/syncthing that referenced this issue Sep 24, 2021
…cthing#4755)

Add various tweaks to the Restore Versions modal in order to make it
more usable in general, and also to prevent the content from breaking
when used with long filenames and on small resolutions.

The specific changes are as follows.

1. Contain the file list in a resizable box, which by defaults occupies
   as much space as needed without overflowing the screen vertically.
   This prevents the whole body from being pushed down by the list, and
   also keeps the filter and confirmation buttons visible on the screen.
2. Forcefully break long filenames with no spaces, so that they always
   fit on the screen.
3. Change the position of the restore buttons' menu popup to the left,
   so that it does not go out of the screen on small resolutions.
4. Widen the filter input fields, so that there is more space for the
   text, and especially the data range fits without being cut off.

Signed-off-by: Tomasz Wilczyński <twilczynski@naver.com>
tomasz1986 added a commit to tomasz1986/syncthing that referenced this issue Sep 25, 2021
…cthing#4755)

Add various tweaks to the Restore Versions modal in order to make it
more usable in general, and also to prevent the content from breaking
when used with long filenames and on small resolutions.

The specific changes are as follows.

1. Contain the file list in a resizable box, which by defaults occupies
   as much space as needed without overflowing the screen vertically.
   This prevents the whole body from being pushed down by the list, and
   also keeps the filter and confirmation buttons visible on the screen.
2. Forcefully break long filenames with no spaces, so that they always
   fit on the screen.
3. Change the position of the restore buttons' menu popup to the left,
   so that it does not go out of the screen on small resolutions.
4. Widen the filter input fields, so that there is more space for the
   text, and especially the data range fits without being cut off.

Signed-off-by: Tomasz Wilczyński <twilczynski@naver.com>
tomasz1986 added a commit to tomasz1986/syncthing that referenced this issue Sep 25, 2021
…cthing#4755)

Add various tweaks to the Restore Versions modal in order to make it
more usable in general, and also to prevent the content from breaking
when used with long filenames and on small resolutions.

The specific changes are as follows.

1. Contain the file list in a resizable box, which by defaults occupies
   as much space as needed without overflowing the screen vertically.
   This prevents the whole body from being pushed down by the list, and
   also keeps the filter and confirmation buttons visible on the screen.
2. Forcefully break long filenames with no spaces, so that they always
   fit on the screen.
3. Change the position of the restore buttons' menu popup to the left,
   so that it does not go out of the screen on small resolutions.
4. Widen the filter input fields, so that there is more space for the
   text, and especially the data range fits without being cut off.

Signed-off-by: Tomasz Wilczyński <twilczynski@naver.com>
tomasz1986 added a commit to tomasz1986/syncthing that referenced this issue Sep 25, 2021
…cthing#4755)

Add various tweaks to the Restore Versions modal in order to make it
more usable in general, and also to prevent the content from breaking
when used with long filenames and on small resolutions.

The specific changes are as follows.

1. Contain the file list in a resizable box, which by defaults occupies
   as much space as needed without overflowing the screen vertically.
   This prevents the whole body from being pushed down by the list, and
   also keeps the filter and confirmation buttons visible on the screen.
2. Forcefully break long filenames with no spaces, so that they always
   fit on the screen.
3. Change the position of the restore buttons' menu popup to the left,
   so that it does not go out of the screen on small resolutions.
4. Widen the filter input fields, so that there is more space for the
   text, and especially the data range fits without being cut off.

Signed-off-by: Tomasz Wilczyński <twilczynski@naver.com>
tomasz1986 added a commit to tomasz1986/syncthing that referenced this issue Sep 25, 2021
…cthing#4755)

Add various tweaks to the Restore Versions modal in order to make it
more usable in general, and also to prevent the content from breaking
when used with long filenames and on small resolutions.

The specific changes are as follows.

1. Contain the file list in a resizable box, which by defaults occupies
   as much space as needed without overflowing the screen vertically.
   This prevents the whole body from being pushed down by the list, and
   also keeps the filter and confirmation buttons visible on the screen.
2. Forcefully break long filenames with no spaces, so that they always
   fit on the screen.
3. Change the position of the restore buttons' menu popup to the left,
   so that it does not go out of the screen on small resolutions.
4. Widen the filter input fields, so that there is more space for the
   text, and especially the data range fits without being cut off.

Signed-off-by: Tomasz Wilczyński <twilczynski@naver.com>
tomasz1986 added a commit to tomasz1986/syncthing that referenced this issue Sep 25, 2021
…cthing#4755)

Add various tweaks to the Restore Versions modal in order to make it
more usable in general, and also to prevent the content from breaking
when used with long filenames and on small resolutions.

The specific changes are as follows.

1. Contain the file list in a resizable box, which by defaults occupies
   as much space as needed without overflowing the screen vertically.
   This prevents the whole body from being pushed down by the list, and
   also keeps the filter and confirmation buttons visible on the screen.
2. Forcefully break long filenames with no spaces, so that they always
   fit on the screen.
3. Change the position of the restore buttons' menu popup to the left,
   so that it does not go out of the screen on small resolutions.
4. Widen the filter input fields, so that there is more space for the
   text, and especially the data range fits without being cut off.

Signed-off-by: Tomasz Wilczyński <twilczynski@naver.com>
tomasz1986 added a commit to tomasz1986/syncthing that referenced this issue Sep 25, 2021
…cthing#4755)

Add various tweaks to the Restore Versions modal in order to make it
more usable in general, and also to prevent the content from breaking
when used with long filenames and on small resolutions.

The specific changes are as follows.

1. Contain the file list in a resizable box, which by defaults occupies
   as much space as needed without overflowing the screen vertically.
   This prevents the whole body from being pushed down by the list, and
   also keeps the filter and confirmation buttons visible on the screen.
2. Forcefully break long filenames with no spaces, so that they always
   fit on the screen.
3. Change the position of the restore buttons' menu popup to the left,
   so that it does not go out of the screen on small resolutions.
4. Widen the filter input fields, so that there is more space for the
   text, and especially the data range fits without being cut off.

Signed-off-by: Tomasz Wilczyński <twilczynski@naver.com>
tomasz1986 added a commit to tomasz1986/syncthing that referenced this issue Sep 25, 2021
…cthing#4755)

Add various tweaks to the Restore Versions modal in order to make it
more usable in general, and also to prevent the content from breaking
when used with long filenames and on small resolutions.

The specific changes are as follows.

1. Contain the file list in a resizable box, which by defaults occupies
   as much space as needed without overflowing the screen vertically.
   This prevents the whole body from being pushed down by the list, and
   also keeps the filter and confirmation buttons visible on the screen.
2. Forcefully break long filenames with no spaces, so that they always
   fit on the screen.
3. Change the position of the restore buttons' menu popup to the left,
   so that it does not go out of the screen on small resolutions.
4. Widen the filter input fields, so that there is more space for the
   text, and especially the data range fits without being cut off.

Signed-off-by: Tomasz Wilczyński <twilczynski@naver.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A problem with current functionality, as opposed to missing functionality (enhancement)
Projects
None yet
Development

No branches or pull requests

4 participants