Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Button Does Not Have Confirmation Dialog #5887

Closed
brettml opened this issue Jul 24, 2019 · 0 comments · Fixed by #6167
Closed

Upgrade Button Does Not Have Confirmation Dialog #5887

brettml opened this issue Jul 24, 2019 · 0 comments · Fixed by #6167
Labels
enhancement New features or improvements of some kind, as opposed to a problem (bug) frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion
Milestone
v1.3.3

Comments

@brettml
Copy link

brettml commented Jul 24, 2019

A stray click on the upgrade button at the top of the web GUI led to an unconfirmed upgrade of Syncthing. Expected behavior would be to have a confirmation dialog asking to upgrade or cancel.

Syncthing Version: v1.0.0 (though presumably current as well - untested in 1.2.0)
@imsodin imsodin added the enhancement New features or improvements of some kind, as opposed to a problem (bug) label Jul 27, 2019
@ruslanye ruslanye mentioned this issue Nov 19, 2019
Merged
calmh pushed a commit that referenced this issue Nov 19, 2019
@ruslanye @calmh
gui: Add upgrade confirmation dialog (fixes #5887) (#6167)
c1db8b2
@calmh calmh added this to the v1.3.3 milestone Nov 21, 2019
@st-review st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label Nov 19, 2020
@syncthing syncthing locked and limited conversation to collaborators Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New features or improvements of some kind, as opposed to a problem (bug) frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion
Projects
None yet
Milestone
v1.3.3
Development

Successfully merging a pull request may close this issue.

gui/default: Add upgrade confirmation dialog (fixes #5887)
4 participants
@calmh @imsodin @st-review @brettml