Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version output is not always the first log line #5891

Closed
calmh opened this issue Jul 27, 2019 · 0 comments
Closed

Version output is not always the first log line #5891

calmh opened this issue Jul 27, 2019 · 0 comments
Labels
bug A problem with current functionality, as opposed to missing functionality (enhancement) frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion skip-changelog Bugs that have never been in a released stable version, and as such excluded from the release notes
Milestone

Comments

@calmh
Copy link
Member

calmh commented Jul 27, 2019

This messes up crash reporting as the version isn't found where expected. Examples:

08:00:35 INFO: No automatic upgrades; STNOUPGRADE environment variable defined.
[MRIW7] 08:00:35 INFO: syncthing v1.2.1-rc.4+4-ge3178a09-dirty-save-less "Fermium Flea" (go1.12.6 darwin-amd64) jb@kvin.kastelo.net 2019-07-27 05:11:17 UTC
[MRIW7] 08:00:35 INFO: My ID: MRIW7OK-NETT3M4-N6SBWME-N25O76W-YJKVXPH-FUMQJ3S-P57B74J-GBITBAC
[MRIW7] 08:00:36 INFO: Single thread SHA256 performance is 499 MB/s using minio/sha256-simd (432 MB/s using crypto/sha256).
[MRIW7] 08:00:36 INFO: Hashing performance is 413.55 MB/s
...
Panic at 2019-07-27T08:00:36+02:00
panic: calmh is testing crash reporting
08:03:34 INFO: Automatic upgrade is always enabled for candidate releases.
[MRIW7] 08:03:34 INFO: syncthing v1.2.1-rc.4+4-ge3178a09-dirty-save-less "Fermium Flea" (go1.12.6 darwin-amd64) jb@kvin.kastelo.net 2019-07-27 05:11:17 UTC
[MRIW7] 08:03:34 INFO: My ID: MRIW7OK-NETT3M4-N6SBWME-N25O76W-YJKVXPH-FUMQJ3S-P57B74J-GBITBAC
[MRIW7] 08:03:35 INFO: Single thread SHA256 performance is 503 MB/s using minio/sha256-simd (435 MB/s using crypto/sha256).
[MRIW7] 08:03:35 INFO: Hashing performance is 417.52 MB/s
...
Panic at 2019-07-27T08:03:35+02:00
panic: calmh is testing crash reporting
@calmh calmh added the bug A problem with current functionality, as opposed to missing functionality (enhancement) label Jul 27, 2019
calmh added a commit to calmh/syncthing that referenced this issue Jul 27, 2019
@calmh calmh added the skip-changelog Bugs that have never been in a released stable version, and as such excluded from the release notes label Jul 27, 2019
calmh added a commit to calmh/syncthing that referenced this issue Jul 27, 2019
* release:
  cmd/syncthing: Print version information early (fixes syncthing#5891) (syncthing#5893)
@calmh calmh modified the milestones: v1.2.2, v1.2.1 Jul 30, 2019
calmh added a commit to calmh/syncthing that referenced this issue Aug 5, 2019
* release:
  cmd/syncthing: Print version information early (fixes syncthing#5891) (syncthing#5893)
@st-review st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label Jul 27, 2020
@syncthing syncthing locked and limited conversation to collaborators Jul 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug A problem with current functionality, as opposed to missing functionality (enhancement) frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion skip-changelog Bugs that have never been in a released stable version, and as such excluded from the release notes
Projects
None yet
Development

No branches or pull requests

2 participants