-no-upgrade broken

[vext01]

Today's master on OpenBSD:

$ go run build.go -no-upgrade
...
github.com/oschwald/geoip2-golang
github.com/syncthing/syncthing/lib/relay/client
golang.org/x/time/rate
github.com/AudriusButkevicius/go-nat-pmp
github.com/syncthing/syncthing/lib/nat
github.com/jackpal/gateway
github.com/syncthing/syncthing/lib/upnp
github.com/syncthing/syncthing/lib/pmp
github.com/syncthing/syncthing/lib/signature
github.com/syncthing/syncthing/cmd/stupgrades
# github.com/syncthing/syncthing/cmd/stupgrades
cmd/stupgrades/main.go:24:10: undefined: upgrade.FetchLatestReleases
cmd/stupgrades/main.go:30:12: undefined: upgrade.SortByRelease
exit status 2
exit status 1

If I remove -no-upgrade build works fine.

If we could get a patch, I can update the OpenBSD port.

Cheers!

[calmh]

Use go run build.go -no-upgrade build or even more explicitly go run build.go -no-upgrade build syncthing to build just the Syncthing binary without upgrades functionality.

The default build.go action with no parameters is to build all binaries, which includes the upgrades server, which cannot build without upgrade code.

[vext01]

It seems that after doing:

go run build.go -no-upgrade build
go run build.go -no-upgrade install

There is only syncthing in the bin/ directory. In the port we currently have in the OpenBSD tree, we install a load of other programs too. Is it possible to build those too without have to list the targets?

Basically, I'd like to install everything that doesn't require upgrade support.

Thanks

[vext01]

Maybe I'm going about this wrongly. I don't mind building the binaries to do with upgrade servers etc, we just can't have syncthing try to auto-update itself, as that would upset our package tools.

[AudriusButkevicius]

The idea is that -no-upgrade acts as a directive that excludes some files, those files are required to build upgrade server, so you either build everything with upgrades, or build just syncthing with no-upgrade (as that is where it has the effect)

[vext01]

I see.

So perhaps what I need to do is build everything without -no-upgrade, then delete the syncthing binary, then rebuild only that with -no-upgrade?

Out of interest how many of the extra binaries are actually useful to users? We currently package:

@bin bin/stbench
@bin bin/stcli
@bin bin/stcompdirs
@bin bin/stdisco
@bin bin/stdiscosrv
@bin bin/stevents
@bin bin/stfileinfo
@bin bin/stfinddevice
@bin bin/stfindignored
@bin bin/stgenfiles
@bin bin/stindex
@bin bin/strelaypoolsrv
@bin bin/strelaysrv
@bin bin/stsigtool
@bin bin/stvanity
@bin bin/stwatchfile
@bin bin/syncthing
@bin bin/testutil
@bin bin/uraggregate
@bin bin/ursrv

[vext01]

To elaborate on that last query, I wonder if it'd be OK to only install the things that have an explicit target in build.go, so that's:

• syncthing
• stdiscosrv
• strelaysrv
• strelaypoolsrv
• stcli

Perhaps those are the only bits end users are realistically interested in?

[AudriusButkevicius]

I think so, upgrade server is quite niche (so is relaypoolsrv), so I don't expect people to run them themselves.

[vext01]

OK, thanks. I'll try only building syncthing, stdiscosrv, strelaysrv and stcli via explicit targets

[vext01]

Hrm. It seems like the build is non-deterministically failing with a seg fault. Sometimes the build passes and I get binaries, others not.

Here's a couple of examples of different crashes:
https://gist.github.com/vext01/ecfa0ba1759dc01718aefaa309aad5b3

The invocation I'm using in my port makefile looks like this:

ST_CMDS =       syncthing stdiscosrv strelaysrv stcl

do-build:
.for cmd in ${ST_CMDS}
	cd ${WRKSRC} && ${MODGO_CMD} run build.go -version v${V} \
		-no-upgrade install ${cmd}
.endfor

I can try master and see if I get the same... (these crashes are for 1.3.0).

[vext01]

Yes, here's a crash on master:
https://gist.github.com/vext01/c6a55fe4e75a5075f51a803e6d6a13e2

This isn't even your code, so I wonder if go is busted on my system...

[calmh]

Yeah crashes in the compiler are outside of our jurisdiction.

[vext01]

Yeah crashes in the compiler are outside of our jurisdiction.

Yeah sorry about the noise. I didn't realise it was the compiler crashing until too late. I'm in discussions with our go packager now.

I'll close this, since I think we've solved the -no-install problem.

Thanks for the help!