lib/db, lib/syncthing: Repair db once on upgrade (ref #6425, #6427) #6429
Conversation
lib/syncthing/syncthing.go
Outdated
| if prevVersion != "" { | ||
| l.Infoln("Detected upgrade from", prevVersion, "to", build.Version) | ||
| // Check and repair metadata and sequences once immediately |
There was a problem hiding this comment.
Why not just do checkrepair on every upgrade for now?
There was a problem hiding this comment.
Doing it on all upgrades including RCs feels like a lot of churn (e.g. considering the 11 RCs last month). And we need it to happen now on v1.4.1-rc.2. So maybe do it on stable updates and v1.4.1-rc.2 explicitly could be a middle way. Or am overthinking and for RC users it's fine to do it on every upgrade?
There was a problem hiding this comment.
Hmm. I didn't consider that we want it to happen between-rc:s this time. However, I wonder if the correct thing here isn't to actually run this on every upgrade, even rc-to-rc. The criteria then would be to split on + and just string-equals compare the thing before the plus (if any).
There was a problem hiding this comment.
I think the full index transfer is a lot heavier than the checks we do, so if anything that would be the part I think we can remove nowadays...
* release: lib/db, lib/syncthing: Repair db once on upgrade (ref syncthing#6425, syncthing#6427) (syncthing#6429) lib/db: Fix removeFromGlobal and no filenames in error (fixes syncthing#6427) (syncthing#6428) lib/db: Remove emptied global list in checkGlobals (fixes syncthing#6425) (syncthing#6426)
st-review
added
the
frozen-due-to-age
Both #6425 and #6427 require a metadata (respectively sequence) recalc. This adds an exported method to
db.Lowlevelto trigger that, which is then done on startup if an upgrade with a previous version <1.4.2 is detected.I moved the code for the recalculation from set.go to lowlevel.go and made them methods of
*Lowlevel(which before got passed as arg). This is entirely copy&paste, except that the previousrecalcfixture now is now a method calledgetMetaAndCheck.I manually tested running a binary from this PR on a db from 1.4.0.