Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

panic: nil pointer dereference in usage reporting #6499

Closed
syncthing-sentry bot opened this issue Apr 6, 2020 · 0 comments
Closed

panic: nil pointer dereference in usage reporting #6499

syncthing-sentry bot opened this issue Apr 6, 2020 · 0 comments
Labels
bug A problem with current functionality, as opposed to missing functionality (enhancement) frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion
Milestone
v1.4.2

Comments

@syncthing-sentry
Copy link 

22:42:48 INFO: syncthing v1.4.1-rc.3 "Fermium Flea" (go1.13.9 windows-amd64) teamcity@build.syncthing.net 2020-03-20 11:07:29 UTC
Panic at 2020-04-03T07:13:20+11:00
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xc0000005 code=0x0 addr=0x40 pc=0xbe8784]

goroutine 45 [running]:
github.com/syncthing/syncthing/lib/ur.(*Service).sendUsageReport(0xc0000a8aa0, 0x1110060, 0xc0024dcec0, 0x1, 0xc003904170)
	C:/BuildAgent/work/174e136266f8a219/lib/ur/usage_report.go:393 +0x444
github.com/syncthing/syncthing/lib/ur.(*Service).serve(0xc0000a8aa0, 0x1110060, 0xc0024dcec0)
	C:/BuildAgent/work/174e136266f8a219/lib/ur/usage_report.go:412 +0x2da
github.com/syncthing/syncthing/lib/util.AsService.func1(0x1110060, 0xc0024dcec0, 0xc002475f20, 0xa76cacda11213bab)
	C:/BuildAgent/work/174e136266f8a219/lib/util/utils.go:183 +0x40
github.com/syncthing/syncthing/lib/util.(*service).Serve(0xc00005ff80)
	C:/BuildAgent/work/174e136266f8a219/lib/util/utils.go:247 +0x149
github.com/thejerf/suture.(*Supervisor).runService.func1(0xc000346b40, 0xc000000003, 0x11061e0, 0xc0000a8aa0)
	C:/BuildAgent/work/pkg/mod/github.com/thejerf/suture@v3.0.2+incompatible/supervisor.go:600 +0x57
created by github.com/thejerf/suture.(*Supervisor).runService
	C:/BuildAgent/work/pkg/mod/github.com/thejerf/suture@v3.0.2+incompatible/supervisor.go:588 +0x62

//@calmh
@calmh calmh added the bug A problem with current functionality, as opposed to missing functionality (enhancement) label Apr 6, 2020
calmh added a commit to calmh/syncthing that referenced this issue Apr 6, 2020
@calmh
lib/ur: Correct freaky error handling (fixes syncthing#6499)
6915c17
@imsodin imsodin closed this as completed in 88cabb9 Apr 6, 2020
@calmh calmh added this to the v1.5.0 milestone Apr 6, 2020
@calmh calmh changed the title panic: runtime error: invalid memory address or nil pointer dereference in usage reporting panic: nil pointer dereference in usage reporting Apr 6, 2020
calmh added a commit to calmh/syncthing that referenced this issue Apr 7, 2020
@calmh
lib/ur: Correct freaky error handling (fixes syncthing#6499) (syncthi…
670a980 
…ng#6500)
@calmh calmh modified the milestones: v1.5.0, v1.4.2 Apr 7, 2020
calmh added a commit that referenced this issue Apr 8, 2020
@calmh
Merge branch 'release'
046bbdf 
* release:
  lib/db: Don't get blocklists on drop and missing continue (ref #6457) (#6502)
  Revert "cmd/syncthing: Do auto-upgrade before startup (fixes #6384) (#6385)"
  lib/ur: Correct freaky error handling (fixes #6499) (#6500)
@st-review st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label Apr 7, 2021
@syncthing syncthing locked and limited conversation to collaborators Apr 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug A problem with current functionality, as opposed to missing functionality (enhancement) frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion
Projects
None yet
Milestone
v1.4.2
Development

No branches or pull requests
2 participants
@calmh @st-review