Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTFS -> VFAT Sync Issue: Folder that contains final space in name is supported by NTFS but not in VFAT #8381

Closed
jorgeprediger opened this issue Jun 10, 2022 · 6 comments
Labels
bug A problem with current functionality, as opposed to missing functionality (enhancement) frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion needs-triage New issues needed to be validated

Comments

@jorgeprediger
Copy link

In the NTFS file system there are directory names with trailing spaces. If the file system of the destination device is VFAT, a synchronization retry is generated that cannot be satisfied because the creation of the directory fails because VFAT does not support spaces at the end of the name.

This is not a bug of syncthing but said problem does not allow the completion of the synchronization.

root@ubuntu-desktop:/mnt/43C7-BE45# export LANG=C
root@ubuntu-desktop:/mnt/43C7-BE45# lsblk -o +FSTYPE /dev/sdb
NAME   MAJ:MIN RM   SIZE RO TYPE MOUNTPOINTS    FSTYPE
sdb      8:16   0   3.6T  0 disk                
|-sdb1   8:17   0 931.3G  0 part                ext4
`-sdb2   8:18   0 931.3G  0 part /mnt/43C7-BE45 vfat
root@ubuntu-desktop:/mnt/43C7-BE45# mkdir 'test '
mkdir: cannot create directory 'test ': Invalid argument
root@ubuntu-desktop:/mnt/43C7-BE45# 

@jorgeprediger jorgeprediger added bug A problem with current functionality, as opposed to missing functionality (enhancement) needs-triage New issues needed to be validated labels Jun 10, 2022
@AudriusButkevicius
Copy link
Member

As you said, it's not a bug of syncthing, this is expected not to work and the solution is to fix your filenames.

@jorgeprediger
Copy link
Author

Please do not close it, in any case they should add a validation and inform the user of the problem, I can determine it because I am an advanced user but someone without technical knowledge could not determine the cause of the problem.

@AudriusButkevicius
Copy link
Member

It's not feasible validation, as there are hundreds of different filesystems with different requirements/restrictions.
There are cases where you can't even identify what type of filesystem is in use, as the filesystems lie (things like overlay filesystems etc).

I don't think there is any point leaving this open as this can't be actioned/closed in anyway.

@jorgeprediger
Copy link
Author

Inform the user that directory synchronization with trailing space is not fully supported and add a pattern to ignore them.

I close it because I understand what it is asking me, even so it is an unwanted situation.

@rasa
Copy link
Member

rasa commented Jun 12, 2022

FYI, #7876 (comment) would address this issue.

But I don't think you can add a pattern to your .stignore file to ignore filenames ending with a space, as trailing spaces are not considered part of the pattern, unless escaped, and the escape character, the backslash, is repurposed to be a path separator on Windows. See here. See @tomasz1986's comment below.

@tomasz1986
Copy link
Contributor

tomasz1986 commented Jun 12, 2022

You actually can ignore them by adding *{ } to the ignore patterns 😉.

@st-review st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label Jun 11, 2023
@syncthing syncthing locked and limited conversation to collaborators Jun 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug A problem with current functionality, as opposed to missing functionality (enhancement) frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion needs-triage New issues needed to be validated
Projects
None yet
Development

No branches or pull requests

5 participants