Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGUI is displayed incorrectly on "tablet sized" screens #8529

Closed
lyaaz opened this issue Sep 7, 2022 · 4 comments
Closed

WebGUI is displayed incorrectly on "tablet sized" screens #8529

lyaaz opened this issue Sep 7, 2022 · 4 comments
Labels
bug A problem with current functionality, as opposed to missing functionality (enhancement) frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion ui Issues related to the graphical user interface
Milestone

Comments

@lyaaz
Copy link

lyaaz commented Sep 7, 2022

Screenshot_20220907-112756_Syncthing

Version Information

App Version: 1.20.4 f-droid build
Syncthing Version: v1.20.4
Android Version: Android 12.1
Device: Xiaomi MI 9
@imsodin
Copy link
Member

imsodin commented Sep 11, 2022

This would be a syncthing issue, as the web gui isn't android specific. However the web UI not working well on small screens is partly why the wrapper UI exists. Plus the syncthing web UI is an old piece of hard to maintain code, if anyone wants to improve anything they are welcome but it's hard and unlikely to happen. Or in other words not worth having an open issue for that.

@imsodin imsodin closed this as completed Sep 11, 2022
@tomasz1986
Copy link
Contributor

tomasz1986 commented Sep 11, 2022

The GUI is actually fine on a small screen. It's the tablet version (which your phone's large screen triggers) that breaks like that. I've seen it break the same way before even on a desktop computer with a small monitor.

@imsodin
Copy link
Member

imsodin commented Sep 11, 2022

@tomasz1986 If you feel this is something that is worth fixing and can be fixed with reasonable effort (no need for you to commit to do it, just your judgment as you have done some work on the UI) - feel free to move the ticket to syncthing and reopen.

@tomasz1986
Copy link
Contributor

I do think this is worth fixing, but I also remember seeing a similar issue in the main repository already. I can't find it now though 😓, but it could be something old (from around ~2015) and without the standard ui label, so not easy to find without going through the issue list by hand.

I will try to check UI-related issues again and mark the old one to fix if I find it, or open a new one in the main repo if it is just my imagination and the issue doesn't actually exist yet.

@imsodin imsodin transferred this issue from syncthing/syncthing-android Sep 11, 2022
@imsodin imsodin changed the title WebGUI is not displayed correctly on 1080p screen with over 420 dpi WebGUI is displayed incorrectly on "tablet sized" screens Sep 11, 2022
@imsodin imsodin reopened this Sep 11, 2022
@imsodin imsodin added ui Issues related to the graphical user interface bug A problem with current functionality, as opposed to missing functionality (enhancement) labels Sep 11, 2022
tomasz1986 added a commit to tomasz1986/syncthing that referenced this issue Sep 11, 2022
Currently, the code contains a "mobile phone" fix to allow wrapping of
long lines in table heading and cells. However, the fix is applied to
all screen sizes equal or below 768 px wide, which causes the layout to
break on tablet-sized screens.

The commit moves the "mobile" fix to the actual mobile media query,
which is applied to screens up to 419 px wide. It is only really needed
there, where it synergises with the existing fix that changes table cell
display to "block". There is no need to wrap the text on larger screens,
as there is more than enough space to display the lines in full on them.

Signed-off-by: Tomasz Wilczyński <twilczynski@naver.com>
@calmh calmh closed this as completed in 7d3c390 Sep 13, 2022
@calmh calmh added this to the v1.22.0 milestone Sep 14, 2022
@st-review st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label Oct 12, 2023
@syncthing syncthing locked and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug A problem with current functionality, as opposed to missing functionality (enhancement) frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion ui Issues related to the graphical user interface
Projects
None yet
Development

No branches or pull requests

5 participants