Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check interface for FlagRunning #8767

Closed
bt90 opened this issue Feb 1, 2023 · 0 comments · Fixed by #9047
Closed

Check interface for FlagRunning #8767

bt90 opened this issue Feb 1, 2023 · 0 comments · Fixed by #9047
Labels
enhancement New features or improvements of some kind, as opposed to a problem (bug)
Milestone
v1.24.0

Comments

@bt90
Copy link
Contributor

bt90 commented Feb 1, 2023

As of #7458 we're checking if an interface is considered up. Go 1.20 added an additional flag which would be more useful:

Interface.Flags now includes the new flag FlagRunning, indicating an operationally active interface. An interface which is administratively configured but not active (for example, because the network cable is not connected) will have FlagUp set but not FlagRunning.
@bt90 bt90 added enhancement New features or improvements of some kind, as opposed to a problem (bug) needs-triage New issues needed to be validated labels Feb 1, 2023
@calmh calmh removed the needs-triage New issues needed to be validated label Feb 1, 2023
This was referenced Aug 19, 2023
Closed
Merged
calmh pushed a commit that referenced this issue Aug 21, 2023
@bt90
lib/osutil, lib/upnp: Check FlagRunning (fixes #8767) (#9047)
c2c6133
@calmh calmh added this to the v1.24.0 milestone Aug 23, 2023
calmh added a commit to calmh/syncthing that referenced this issue Sep 1, 2023
@calmh
Merge branch 'main' into newglobbing
a6f61f7 
* main: (121 commits)
  build: Update dependencies
  gui: Remove footer and move links to header (fixes syncthing#5607) (syncthing#9067)
  gui: Fix lastSeenDays error due to undefined deviceStats when adding new devices (ref syncthing#8730) (syncthing#9066)
  gui: Automatically select device ID on click (ref syncthing#8544) (syncthing#9065)
  gui: Prevent modifications when saving changes (fixes syncthing#9019) (syncthing#9063)
  gui: Show in GUI if limitBandwidthInLan is enabled (syncthing#9062)
  lib/upgrade: Enable HTTP/2 for upgrade checks (syncthing#9060)
  lib/discover: Enable HTTP/2 for global discovery requests (syncthing#9059)
  cmd/stdiscosrv: Streamline context handling
  cmd/stdiscosrv: Explicitly enable HTTP/2
  gui, man, authors: Update docs, translations, and contributors
  cmd/stdiscosrv: Separate HTTPS and replication certificates
  cmd/stdiscosrv: Use larger database settings
  cmd/stdiscosrv: Modernise TLS settings, remove excessive HTTP logging
  cmd/stdiscosrv: Serve compressed responses
  lib/connections: Allow IPv6 ULA in discovery announcements (fixes syncthing#7456) (syncthing#9048)
  lib/beacon: Check FlagRunning (syncthing#9051)
  all: Remove lib/util package (syncthing#9049)
  lib/model: Clean up index handler life cycle (fixes syncthing#9021) (syncthing#9038)
  lib/osutil, lib/upnp: Check FlagRunning (fixes syncthing#8767) (syncthing#9047)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New features or improvements of some kind, as opposed to a problem (bug)
Projects
None yet
Milestone
v1.24.0
Development

Successfully merging a pull request may close this issue.

lib/osutil, lib/upnp: Check FlagRunning bt90/syncthing
2 participants
@calmh @bt90