Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go 1.21.4 path handling changes breaks Windows build #9207

Closed
calmh opened this issue Nov 9, 2023 · 1 comment
Closed

Go 1.21.4 path handling changes breaks Windows build #9207

calmh opened this issue Nov 9, 2023 · 1 comment
Labels
bug A problem with current functionality, as opposed to missing functionality (enhancement) build Issues caused by or requiring changes to the build system (scripts or Docker image)

Comments

@calmh
Copy link
Member

calmh commented Nov 9, 2023

Go 1.21.4 contains a security fix for \??\ type paths on Windows, but, apparently, also some other changes to slash handling.

Screenshot 2023-11-09 082312
@calmh calmh added the bug A problem with current functionality, as opposed to missing functionality (enhancement) label Nov 9, 2023
@calmh
Copy link
Member Author

calmh commented Nov 9, 2023

Seeking clarification in golang/go#64028

@calmh calmh added the build Issues caused by or requiring changes to the build system (scripts or Docker image) label Nov 9, 2023
calmh added a commit that referenced this issue Nov 13, 2023
@calmh
build: Version constraint to avoid Go 1.21.4 on Windows (ref #9207) (#…
e477777 
…9213)
calmh added a commit to calmh/syncthing that referenced this issue Nov 14, 2023
@calmh
Merge branch 'main' into basiccachebust
b6bf988 
* main:
  cmd/stdiscorv: Expose build info in metrics
  gui: Fix Weblate merge conflict (syncthing#9222)
  build: Fixup Docker changes from previous (syncthing#9223)
  Add `org.opencontainers.image.source` to Dockerfiles (syncthing#9211)
  build: Update dependencies
  gui: Use nested namespace for theme name translation keys (syncthing#9220)
  Support explicit translation ID and dotted namespaces in translation extraction  (syncthing#9192)
  lib/api: Improve cookie handling (fixes syncthing#9208) (syncthing#9214)
  test: Update testing configs
  build: Use actual Go version as cache key (syncthing#9216)
  build: Version constraint to avoid Go 1.21.4 on Windows (ref syncthing#9207) (syncthing#9213)
calmh added a commit to calmh/syncthing that referenced this issue Nov 15, 2023
@calmh
build: Version constraint to avoid Go 1.21.4 on Windows (ref syncthin…
07ad2db 
…g#9207) (syncthing#9213)
calmh added a commit to calmh/syncthing that referenced this issue Dec 6, 2023
@calmh
Revert "build: Version constraint to avoid Go 1.21.4 on Windows (ref s…
7831833 
…yncthing#9207) (syncthing#9213)"

This reverts commit e477777.
@calmh calmh closed this as completed Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A problem with current functionality, as opposed to missing functionality (enhancement) build Issues caused by or requiring changes to the build system (scripts or Docker image)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@calmh