Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permission error on folder causes "connection error" dialog when opening folder editor #9253

Closed
calmh opened this issue Dec 3, 2023 · 0 comments
Closed

Permission error on folder causes "connection error" dialog when opening folder editor #9253

calmh opened this issue Dec 3, 2023 · 0 comments
Labels
bug A problem with current functionality, as opposed to missing functionality (enhancement) needs-triage New issues needed to be validated
Milestone
v1.27.1

Comments

@calmh
Copy link
Member

calmh commented Dec 3, 2023 •
edited

https://forum.syncthing.net/t/unable-to-delete-folder/21195
@calmh calmh added bug A problem with current functionality, as opposed to missing functionality (enhancement) needs-triage New issues needed to be validated labels Dec 3, 2023
calmh added a commit to calmh/syncthing that referenced this issue Dec 3, 2023
@calmh
lib/api: Improve ignore loading error handling (fixes syncthing#9253)
80590a1 
Any errors that were not a ParseError were returned as an API failure
rather than an error with the ignore file. This was quite limiting and
short sighted, since there may be permission errors, path format errors,
and possibly other things that are in fact legitimate problems with
loading the ignore file and not a bug or connection problem.

Returning a 500 error to the GUI causes the GUI to display a connection
error, which is never desirable here.
@calmh calmh closed this as completed in 7b1932d Dec 4, 2023
@calmh calmh added this to the v1.27.1 milestone Dec 5, 2023
calmh added a commit to calmh/syncthing that referenced this issue Dec 5, 2023
@calmh
Merge branch 'main' into androidfatdst
48ec761 
* main:
  lib/fs: Reduce memory usage in xattrs handling (syncthing#9251)
  lib/model: Improve LastSeen handling (syncthing#9256)
  lib/scanner: Record inode change time for directories and symlinks (syncthing#9250)
  lib/api: Improve ignore loading error handling (fixes syncthing#9253) (syncthing#9254)
  gui, man, authors: Update docs, translations, and contributors
  lib/fs: Better equality comparison in mtimefs
  cmd/stcrashreceiver: Add metrics for diskstore inventory
  cmd/stcrashreceiver: Minor cleanup, stricter file permissions
  cmd/stcrashreceiver: Add metrics for incoming reports
  cmd/ursrv: Add metrics for incoming reports
  gui, man, authors: Update docs, translations, and contributors
  gui: Specialize a special-purpose checkbox style (syncthing#9236)
  gui, man, authors: Update docs, translations, and contributors
  build: Support new nested namespaces in Weblate downloads
  lib/model: Acquire fmut lock in ensureIndexHandler (fixes syncthing#9234) (syncthing#9235)
  gui: Allow to translate "unknown device" (syncthing#9229)
calmh added a commit to cjc7373/syncthing that referenced this issue Dec 11, 2023
@calmh
Merge branch 'main' into cli-framework
e44b2e2 
* main: (69 commits)
  lib/nat: Fix test build failure (ref syncthing#9010)
  lib/model: Add pmut locking for DeviceStatistics (fixes syncthing#9274)
  lib/model: Add pmut locking for DeviceStatistics (fixes syncthing#9274)
  lib/model: Remove spurious "replacing service" failure event (ref syncthing#9271)
  lib/model: Remove spurious "replacing service" failure event (ref syncthing#9271)
  lib/nat, lib/upnp: IPv6 UPnP support (syncthing#9010)
  gui, man, authors: Update docs, translations, and contributors
  gui: Show folder/device status on small screens (syncthing#8643)
  lib/model: Remove runner during folder cleanup (fixes syncthing#9269) (syncthing#9271)
  build: Update dependencies (syncthing#9265)
  build: Revert specifics for Go 1.21.4, build using Go 1.21.5 (syncthing#9264)
  lib/fs: Reduce memory usage in xattrs handling (syncthing#9251)
  lib/model: Improve LastSeen handling (syncthing#9256)
  lib/scanner: Record inode change time for directories and symlinks (syncthing#9250)
  lib/api: Improve ignore loading error handling (fixes syncthing#9253) (syncthing#9254)
  gui, man, authors: Update docs, translations, and contributors
  lib/fs: Better equality comparison in mtimefs
  cmd/stcrashreceiver: Add metrics for diskstore inventory
  cmd/stcrashreceiver: Minor cleanup, stricter file permissions
  cmd/stcrashreceiver: Add metrics for incoming reports
  ...
@calmh calmh mentioned this issue Dec 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A problem with current functionality, as opposed to missing functionality (enhancement) needs-triage New issues needed to be validated
Projects
None yet
Milestone
v1.27.1
Development

No branches or pull requests
1 participant
@calmh