Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gui: Favicon not working in Firefox bookmarks #9506

Closed
medusalix opened this issue Apr 9, 2024 · 1 comment
Closed

gui: Favicon not working in Firefox bookmarks #9506

medusalix opened this issue Apr 9, 2024 · 1 comment
Labels
bug A problem with current functionality, as opposed to missing functionality (enhancement) needs-triage New issues needed to be validated
Milestone
v1.27.8

Comments

@medusalix
Copy link
Contributor

What happened?

Firefox doesn't show any favicon at all when adding a bookmark to the Syncthing GUI, even with the static favicon introduced by #8850. It looks like Firefox prefers the last favicon that is found in <head> which is the link to favicon-{{syncthingStatus()}}.png. Because that file is not available on initial page load, it is not considered for bookmarks. The favicon logic for Firefox can be found here.
Switching the order of the favicon links in <head> fixes the behavior for Firefox while breaking the dynamic favicon for Chromium-based browsers.
A proper fix for this issue was suggested by @ajshea in #7638 (comment).

Syncthing version

v1.27.6

Platform & operating system

Linux x86

Browser version

Firefox 124.0.2

Relevant log output

No response
@medusalix medusalix added bug A problem with current functionality, as opposed to missing functionality (enhancement) needs-triage New issues needed to be validated labels Apr 9, 2024
@calmh calmh closed this as completed in ebb1edc May 1, 2024
calmh added a commit to calmh/syncthing that referenced this issue May 9, 2024
@calmh
Merge branch 'main' into geoip
e2d1963 
* main: (45 commits)
  build: Use Go 1.22.3 at minimum
  build: Use Go 1.22.3 at minimum
  gui: Add Hindi (hi) translation template (syncthing#9530)
  gui, man, authors: Update docs, translations, and contributors
  lib/connections: Add syncthing_connections_active metric (fixes syncthing#9527) (syncthing#9528)
  etc: Use 7MiB buffer size (syncthing#9524)
  gui: Fix Firefox bookmark favicon (fixes syncthing#9506) (syncthing#9507)
  gui, man, authors: Update docs, translations, and contributors
  gui, man, authors: Update docs, translations, and contributors
  gui, man, authors: Update docs, translations, and contributors
  lib/nat: Don't crash on empty address list (fixes syncthing#9503) (syncthing#9504)
  lib/db: Drop indexes for outgoing data to force refresh (ref syncthing#9496) (syncthing#9502)
  gui: Fix missing link to device editor for names with superscript (ref syncthing#9472) (syncthing#9494)
  lib/db: Hold update lock while taking snapshot (syncthing#9496)
  build: Update dependencies (syncthing#9497)
  gui, man, authors: Update docs, translations, and contributors
  gui, man, authors: Update docs, translations, and contributors
  Removed no longer relevant Bountysource link (syncthing#9480)
  lib/api: Missing return after HTTP error
  lib/api: Extract session store (syncthing#9425)
  ...
@calmh calmh added this to the v1.27.8 milestone May 22, 2024
calmh added a commit to calmh/syncthing that referenced this issue May 24, 2024
@calmh
Merge branch 'main' into indexrefactor2
14bbd3a 
* main: (47 commits)
  gui, man, authors: Update docs, translations, and contributors
  build: Use Go 1.22.3 at minimum
  gui: Add Hindi (hi) translation template (syncthing#9530)
  gui, man, authors: Update docs, translations, and contributors
  lib/connections: Add syncthing_connections_active metric (fixes syncthing#9527) (syncthing#9528)
  etc: Use 7MiB buffer size (syncthing#9524)
  gui: Fix Firefox bookmark favicon (fixes syncthing#9506) (syncthing#9507)
  gui, man, authors: Update docs, translations, and contributors
  gui, man, authors: Update docs, translations, and contributors
  gui, man, authors: Update docs, translations, and contributors
  lib/nat: Don't crash on empty address list (fixes syncthing#9503) (syncthing#9504)
  lib/db: Drop indexes for outgoing data to force refresh (ref syncthing#9496) (syncthing#9502)
  gui: Fix missing link to device editor for names with superscript (ref syncthing#9472) (syncthing#9494)
  lib/db: Hold update lock while taking snapshot (syncthing#9496)
  build: Update dependencies (syncthing#9497)
  gui, man, authors: Update docs, translations, and contributors
  gui, man, authors: Update docs, translations, and contributors
  Removed no longer relevant Bountysource link (syncthing#9480)
  lib/api: Missing return after HTTP error
  lib/api: Extract session store (syncthing#9425)
  ...
@LinuxOnTheDesktop
Copy link

I still have a problem with Syncthing bookmark icons, on Syncthing 1.27.8. Or rather I have the following two problems.

  1. On Firefox 126.0.1 I get a Syncthing icon but it includes an exclamation mark even though so far as I can tell all is well with Syncthing.

  2. On Firefox 1115.11esr, I get no icon at all.

In the case of each of cases 1 and 2 I deleted an existing Syncthing bookmark before, on Syncthing 1.27.8, adding a new one. It seems to make now difference how I add the bookmark. In both cases (1 and 2) I tried only adding a bookmark to the bookmarks bar.

Perhaps I do something wrongly.

SimonPickup added a commit to MobiusSync/syncthing that referenced this issue Jun 15, 2024
@SimonPickup
Merge tag 'v1.27.8' into ios_try_syncthing_v1.27.8
a675d1a 
v1.27.8

Bugfixes:

- syncthing#9506: gui: Favicon not working in Firefox bookmarks

Enhancements:

- syncthing#9527: Device connection state metric
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A problem with current functionality, as opposed to missing functionality (enhancement) needs-triage New issues needed to be validated
Projects
None yet
Milestone
v1.27.8
Development

No branches or pull requests
3 participants
@calmh @medusalix @LinuxOnTheDesktop