[WIP] Selective sync

[AudriusButkevicius]

Basically, request for comments/help regarding this pruner business, as it looks really bad.

Especially the fact that I can't toggle stuff on or off without having to go through the config, and relying on the order the AJAX calls are made to potentially detect that the flag has been toggled.

Alternatively I could rely on a nil slice to indicate it's on or off, but that's easy to mess up from the API consumer perspective.

[calmh]

Couldn't both ShouldSkipFile and ShouldSkipDir be a simple check for filepath.HasPrefix on any of the patterns? The answer is only yes if it's a dir mentioned directly, or some subpath of a mentioned dir, no?

[AudriusButkevicius]

Well a file will never be a prefix of any of the patterns.
A pattern might be a prefix to one of the files, but that does not imply that we need to sync it, as the base directory of the file has to explicitly match the pattern (minus the [^/]+) bit?

[AudriusButkevicius]

Also, I guess I should add / to all dir patterns and to all dir paths passed in.

[calmh]

Looks generally sane to me, as far as the pruner stuff goes. The GetSelections() is 😱 so I avoided looking at that one so far, and the GUI stuff. :)

[calmh]

@st-jenkins retest this please

[AudriusButkevicius]

@st-jenkins run integration tests please

[AudriusButkevicius]

Need to address the comment I made, and some tests.

[AudriusButkevicius]

So pruner now deals with \\ vs / in filepaths.

The part which builds the tree sort of does too, but doesn't do proper anchoring (ending patterns with /), hence a pattern a/b/c would still match both a/b/c and a/b/cow.
Ideally we could reuse the pruner there (to potentially make the code less ugly), but that would increase runtime, due to having iterate N patterns 3 times (for self, parent, grandparent), versus how it's now, potentially no iteration, up to a maximum of 1 iteration over N patterns.

[calmh]

(I've taken over this branch and rebased it on top of current master, will close this as this is out of date; look for a new one in time.)