Add (?d) ignore prefix, allowing them to be deleted #2944
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if m == nil { | ||
| return false | ||
| return Result{false, false} |
There was a problem hiding this comment.
I'd generally prefer to see these as Result{include: false, deletable: false} to be explicit about what the various booleans are, or maybe just a Result{} as the zero value is a non-deletable non-included non-match, or as a named constant as we return it in a couple of places. But this is just a style opinion.
|
Looks awesome apart from the nit about the |
AudriusButkevicius
force-pushed
the
igdel
branch
from
67b3203
to
045a8b1
Compare
|
Updated. |
|
@st-review merge this please lib/ignore: Implement deletable ignores using (?d) prefix (fixes #1362) |
|
OK, merged as 5a98af6. Thanks, @AudriusButkevicius! |
st-review
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Adds a (?d) prefix which marks the file as deletable, so that when we are deleting a directory, we can delete anything that is ignored and in our way.
Also, removes the need to specify the prefixes in a certain order.
Testing
Users will tell me if I deleted all of their photos
Screenshots
Documentation
Need some