build: Clean up "go vet" and "go lint" steps #2972
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // The actual return code is usually an uint16 (not sure why Go | ||
| // uses uint32). The high 8 bits of that are the exit code from | ||
| // the process, the lower 8 bits are signal info. | ||
| return int(code >> 8) |
There was a problem hiding this comment.
Why is this more magical than:
https://github.com/syncthing/syncthing/blob/master/cmd/syncthing/monitor.go#L146
There was a problem hiding this comment.
|
I've fixed the exit status checking stupidity, thanks for catching it. |
|
@st-review merge |
|
🕐 Build status is |
st-review
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Vet was ugly, and was ignoring a composite literal warning for historical reasons. There is no reason to ignore it now. Also doing a bit better detection of the difference between an error because vet complains and an error because vet isn't installed.