Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup, unused code #3004

Closed
wants to merge 1 commit into from
Closed

cleanup, unused code #3004

wants to merge 1 commit into from

Conversation

lkwg82
Copy link
Contributor

@lkwg82 lkwg82 commented Apr 22, 2016

Purpose

cleanup, remove unused code while reading the source

Testing

compile

@AudriusButkevicius
Copy link
Member

@st-review merge

@st-review
Copy link

⛔ Merge failed:

$ git fetch -f origin refs/pull/3004/head:pr-3004
$ git fetch -f origin master:orig/master
$ git reset --hard
HEAD is now at 4aa6ecb lib/model: Do not use WRONLY (ref #2584)
$ git checkout master
Already on 'master'
Your branch is up-to-date with 'origin/master'.
$ git reset --hard orig/master
HEAD is now at 4aa6ecb lib/model: Do not use WRONLY (ref #2584)
$ git clean -fxd
Skipping repository syncthing/syncthing
$ git merge --squash --no-commit pr-3004
Updating 4aa6ecb..98bfd31
Fast-forward
Squash commit -- not updating HEAD
 lib/config/wrapper.go | 5 -----
 1 file changed, 5 deletions(-)
$ git commit -F -
******************************************************
* Commit message does not match the expected format: *
*                                                    *
*   some/tag: A longer description (fixes #1234)     *
*                                                    *
******************************************************

@AudriusButkevicius
Copy link
Member

@st-review merge

lib/config: Remove dead code

@st-review
Copy link

👌 Merged as dffc345. Thanks, @lkwg82!

st-review pushed a commit that referenced this pull request Apr 22, 2016
@st-review st-review closed this Apr 22, 2016
@AudriusButkevicius AudriusButkevicius deleted the lkwg82-patch-2 branch April 22, 2016 20:32
@st-review st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label Jun 16, 2017
@syncthing syncthing locked and limited conversation to collaborators Jun 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants