lib/config: Don't migrate non-HTTPS-URL discovery servers to new path #3104
Conversation
| panic(err) | ||
| } | ||
| uri.Path += "v2/" | ||
| uri, err := url.Parse(addr) |
There was a problem hiding this comment.
"default" and so on are valid URLs with an empty scheme and will slip through this untouched.
|
I guess I'd rather bump config version and release 13.1? |
|
Why increment config? To fix it back you mean? I don't think we have that many users with |
|
Well, I guess it doesn't hurt to do so anyway just to capture those two cases. |
|
Ok, but still lets do a 0.13.1 so this wouldn't be contagious? @st-review merge |
|
I'd rather wait a little longer to see what else pops up so we don't have to release a .2 in fifteen minutes. We can't release much more before we need to start removing releases or we'll leave v0.12.23 behind :( |
|
Hang on and I'll add a v15 migration |
|
I guess we can remove 0.13.0 once 0.13.1 is out? |
|
There. Fixed in the original, and an additional to undo the damage. |
|
Yeah, we could. It's a bit ugly though. I think we can wait a day and collect a few more fixes into .1. |
|
@st-review merge |
st-review
added
the
frozen-due-to-age
Purpose
Don't screw up unknown URLs in the migration (i.e.
default-v4->default-v4v2/). Don't panic.Testing
Tested manually on a v13 config...