cmd/syncthing: Rename event LocalDiskUpdated -> LocalChangeDetected #3121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this better reflects what it means. Also tweaks the verbose format to be more like our other things and lightly refactors the code to not have the boolean and include the folder in the event.
|
@st-review merge |
st-review
pushed a commit
that referenced
this pull request
May 19, 2016
I think this better reflects what it means. Also tweaks the verbose format to be more like our other things and lightly refactors the code to not have the boolean and include the folder in the event. GitHub-Pull-Request: #3121
st-review
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Amends the previous commit adding the LocalDiskUpdated event.
I think this naming better reflects what it means. Also tweaks the verbose format to be more like our other things and lightly refactors the code to not have the boolean and include the folder in the event.
Testing
Tested manually with -verbose and watching output while touch, editing and deleting files.
Documentation
Needs an addition to the event list, which I'll do when this is in.