cmd/syncthing: Enforce stricter CSRF policy on /rest GET requests (fixes #3134) #3137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@st-review merge |
|
I feel this is bad enough that we should make a v12 release too |
|
Mmm |
st-review
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This removes the ability to do "raw" GET requests to the /rest interface. All requests must be accompanied with either an API key or a CSRF token (plus authentication, if configured).
Testing
New unit test added to verify this behavior. GUI tested manually, still appears to work.
Documentation
This needs to be updated in https://docs.syncthing.net/dev/rest.html